Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refacto: some improvements #20

Merged
merged 2 commits into from
Jan 18, 2023
Merged

refacto: some improvements #20

merged 2 commits into from
Jan 18, 2023

Conversation

Kawacrepe
Copy link
Member

@Kawacrepe Kawacrepe commented Jan 18, 2023

Flagged authors will now be at the root of the response
isPublishers is removed, when an author has an at property it means he's also a publisher

@Kawacrepe
Copy link
Member Author

@fraxken What do you think ?
It should cover all the enhancements proposed last sunday? And should allow us to refactor the integration PR in scanner

src/index.d.ts Show resolved Hide resolved
src/index.d.ts Outdated Show resolved Hide resolved
src/index.d.ts Outdated Show resolved Hide resolved
src/index.d.ts Outdated Show resolved Hide resolved
@Kawacrepe Kawacrepe marked this pull request as ready for review January 18, 2023 19:42
Copy link
Member

@fraxken fraxken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kawacrepe Kawacrepe merged commit b8b5485 into main Jan 18, 2023
@fraxken fraxken deleted the refactor--refact branch January 21, 2023 10:25
Rossb0b pushed a commit to Rossb0b/authors that referenced this pull request Feb 16, 2023
* refacto: some improvements

* fix: review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants