Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore add command to manage runtime configuration #104

Merged
merged 9 commits into from
Aug 16, 2022

Conversation

Kawacrepe
Copy link
Member

@Kawacrepe Kawacrepe commented Apr 27, 2022

Close #100

This PR aims to add the foundations for managing .nodesecurerc through the CLI.

What is the default .nodesecurec configuration we want to create with nsecure config create ?
Atm I use the 'complete'

There is some improvements to do here:

  • Add the messages into @nodesecure/i18n
  • Maybe improve the cli "style" ?
  • Handling different 'code editor', but that is a 'complex' problematic. I think we should make a dedicated

I'll create the different issues when this PR will be merged

src/commands/config.js Outdated Show resolved Hide resolved
src/commands/config.js Show resolved Hide resolved
@fraxken
Copy link
Member

fraxken commented Apr 28, 2022

Right now i would say that the default configuration we want is minimal (maybe you could add an option to customize the mode when we use the command).

@Kawacrepe Kawacrepe marked this pull request as ready for review April 28, 2022 19:48
@Kawacrepe Kawacrepe requested a review from fraxken May 2, 2022 12:10
Copy link
Member

@fraxken fraxken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/commands/config.js Show resolved Hide resolved
src/commands/config.js Show resolved Hide resolved
@fraxken fraxken merged commit 34ce270 into master Aug 16, 2022
@fraxken fraxken deleted the chore--add-command-to-manage-runtime-configuration branch August 16, 2022 19:35
@fraxken
Copy link
Member

fraxken commented Aug 16, 2022

@allcontributors please add @Kawacrepe for code, bug

@allcontributors
Copy link
Contributor

@fraxken

I've put up a pull request to add @Kawacrepe! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new CLI commands to manage the runtime configuration
2 participants