Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate from tap to node test runner #202

Merged
merged 3 commits into from
Jun 3, 2023
Merged

Conversation

PierreDemailly
Copy link
Member

@PierreDemailly PierreDemailly requested a review from a team May 30, 2023 17:32
@PierreDemailly
Copy link
Member Author

Bundlephobia is down.

Copy link
Member

@tony-go tony-go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good code-wise 🎉

@PierreDemailly PierreDemailly changed the title chore: update badges refactor: migrate from tap to node test runner Jun 1, 2023
@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: +87.03 🎉

Comparison is base (6fd97aa) 0.00% compared to head (5078416) 87.03%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #202       +/-   ##
===========================================
+ Coverage        0   87.03%   +87.03%     
===========================================
  Files           0       15       +15     
  Lines           0      648      +648     
===========================================
+ Hits            0      564      +564     
- Misses          0       84       +84     

see 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fraxken
Copy link
Member

fraxken commented Jun 2, 2023

@PierreDemailly maybe squash before merging? (if you maybe want to keep 2 or 3 distincts commits)

@PierreDemailly PierreDemailly merged commit f89c9d5 into master Jun 3, 2023
10 checks passed
@PierreDemailly PierreDemailly deleted the update-badges branch June 3, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants