Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pallet-grants): prevent a transaction failure #624

Merged
merged 1 commit into from Jun 17, 2022

Conversation

aliXsed
Copy link
Contributor

@aliXsed aliXsed commented Jun 17, 2022

prevent a transaction failure when cancel_all_vesting_schedules was not limited to the free balance

…ting_schedules was not limited to the free balance
@rajesh-nodle
Copy link
Contributor

LGTM

Copy link
Contributor

@rajesh-nodle rajesh-nodle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #624 (b8aefd4) into master (026bd9b) will decrease coverage by 0.01%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master     #624      +/-   ##
==========================================
- Coverage   89.38%   89.37%   -0.02%     
==========================================
  Files          40       40              
  Lines        6295     6294       -1     
==========================================
- Hits         5627     5625       -2     
- Misses        668      669       +1     
Impacted Files Coverage Δ
pallets/grants/src/lib.rs 64.28% <66.66%> (-1.38%) ⬇️
pallets/grants/src/benchmarking.rs 100.00% <100.00%> (ø)
pallets/grants/src/tests.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 026bd9b...b8aefd4. Read the comment docs.

@aliXsed aliXsed merged commit 8e4bc69 into master Jun 17, 2022
@aliXsed aliXsed deleted the alix/limit-cancel-vesting-to-free-balance branch June 17, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants