Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence a few clippy warnings #629

Merged
merged 2 commits into from Jul 11, 2022
Merged

Silence a few clippy warnings #629

merged 2 commits into from Jul 11, 2022

Conversation

simonsso
Copy link
Collaborator

@simonsso simonsso commented Jul 7, 2022

Should make the build clean.

Removed 1 * something it existed only for consistency with other values in the lists

derive_partial_eq_without_eq implemented suggestion but another source was included in the same file so I also silenced it

#[allow(clippy::type_complexity)] yes the types are complex let's just acknowledge that

#[allow(clippy::boxed_local)] not sure if we should change the code or silence the warning so I silenced it.

@simonsso simonsso requested a review from a team July 7, 2022 02:44
@aliXsed
Copy link
Contributor

aliXsed commented Jul 7, 2022

@simonsso Thank you for making the effort to remove the clippy warnings.

@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #629 (4fdc6df) into master (98e53aa) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #629   +/-   ##
=======================================
  Coverage   89.42%   89.42%           
=======================================
  Files          37       37           
  Lines        6229     6229           
=======================================
  Hits         5570     5570           
  Misses        659      659           
Impacted Files Coverage Δ
node/src/chain_spec.rs 0.00% <ø> (ø)
node/src/service.rs 0.00% <ø> (ø)
pallets/mandate/src/lib.rs 0.00% <ø> (ø)
pallets/reserve/src/lib.rs 48.64% <ø> (ø)
pallets/staking/src/lib.rs 85.57% <ø> (ø)
runtimes/eden/src/pallets_system.rs 0.00% <ø> (ø)
runtimes/eden/src/pallets_util.rs 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98e53aa...4fdc6df. Read the comment docs.

@simonsso simonsso requested a review from a team July 11, 2022 05:25
@simonsso
Copy link
Collaborator Author

I think this is ready to be merged, please review.

@simonsso simonsso merged commit ee44942 into master Jul 11, 2022
@simonsso simonsso deleted the fredrik/removewarnings1 branch July 11, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants