Remove without_storage_info for the poa pallet - V2 #633
Conversation
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
Codecov Report
@@ Coverage Diff @@
## master #633 +/- ##
==========================================
- Coverage 89.74% 89.73% -0.01%
==========================================
Files 33 33
Lines 6238 6232 -6
==========================================
- Hits 5598 5592 -6
Misses 640 640
Continue to review full report at Codecov.
|
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
…chain into shamb0/v2_bounded_poa
pallets/staking/src/lib.rs
Outdated
| @@ -34,7 +34,10 @@ pub mod weights; | |||
|
|
|||
| use frame_support::pallet; | |||
| pub(crate) mod hooks; | |||
| mod migrations; | |||
|
|
|||
| // TODO:: Take it part of PR621 | |||
There was a problem hiding this comment.
I suppose it needs to be pulled in as part of #621?
There was a problem hiding this comment.
Yup, has to be taken care part of #621
There was a problem hiding this comment.
Is it possible that we don't make any changes to this file as part of this PR?
There was a problem hiding this comment.
No, right now not possible, mainly due to the requirements of moving validatorsets from pallet members to invulnerables storage.
|
A few questions, but otherwise LGTM. If this PR should be merged in a certain order (relating to other work that is currently in-flight), that would be helpful to know for future reference. |
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
Part of #173
HighLights
Validatorsis moved to bounded vector.Oraclesis Configured viaMaxValidators.ValidatorsUpdated(u32)&ValidatorsMaxOverflow(u32, u32)TODO
Ready for final Intake Review