Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to CI/CD build try-runtime error #637

Merged
merged 1 commit into from Jul 13, 2022

Conversation

rajesh-nodle
Copy link
Contributor

try-runtime target needs +nightly toolchain to be default ...

Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
@rajesh-nodle rajesh-nodle requested a review from a team July 13, 2022 08:50
@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #637 (21aefb4) into master (bc93fd8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #637   +/-   ##
=======================================
  Coverage   89.41%   89.41%           
=======================================
  Files          34       34           
  Lines        6234     6234           
=======================================
  Hits         5574     5574           
  Misses        660      660           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc93fd8...21aefb4. Read the comment docs.

Copy link

@secretfader secretfader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting the installation as default seems to have worked. LGTM.

@simonsso simonsso merged commit a2e0288 into master Jul 13, 2022
@simonsso simonsso deleted the shamb0/ci-build-try-runtime-fix branch July 13, 2022 21:56
rajesh-nodle added a commit that referenced this pull request Jul 18, 2022
* remove without_storage_info

Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>

* Update pallets/allocations/src/lib.rs

Co-authored-by: Fredrik Simonsson <simson@thesimson.net>

* Update pallets/allocations/src/lib.rs

Co-authored-by: Fredrik Simonsson <simson@thesimson.net>

* Update pallets/allocations/src/lib.rs

Co-authored-by: Fredrik Simonsson <simson@thesimson.net>

* Fix to CI/CD build try-runtime error

Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>

* Fix to CI/CD build try-runtime error (#637)

* chore: prepare for releasing 2.0.21 (#638)

* remove without_storage_info

Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>

* Update pallets/allocations/src/lib.rs

Co-authored-by: Fredrik Simonsson <simson@thesimson.net>

* Update pallets/allocations/src/lib.rs

Co-authored-by: Fredrik Simonsson <simson@thesimson.net>

* Update pallets/allocations/src/lib.rs

Co-authored-by: Fredrik Simonsson <simson@thesimson.net>

* Update pallets/allocations/src/lib.rs

Co-authored-by: Alex Sedighi <alex@nodle.co>

* Update pallets/allocations/src/lib.rs

Co-authored-by: Alex Sedighi <alex@nodle.co>

* intake review suggestions

Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>

Co-authored-by: R.Rajeshkumar <rajesh@nodle.com>
Co-authored-by: Fredrik Simonsson <simson@thesimson.net>
Co-authored-by: Alex Sedighi <alex@nodle.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants