Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to polkadot v0.9.26 #646

Merged
merged 31 commits into from Aug 2, 2022
Merged

Conversation

rajesh-nodle
Copy link
Contributor

@rajesh-nodle rajesh-nodle commented Jul 28, 2022

Fixes #631

Completed

  • pallets
    • allocations :: Done
    • grants :: Done
    • mandate :: Done
    • poa :: Done
    • reserve :: Done
    • staking :: Done
  • Runtime
    * eden :: Done

  • node :: Done

  • Benchmarking on all Pallets :: Done

  • Integration test :: Done

  • Runtime or storage upgrade ( Node Client or Host needs to be latest v0.9.26 ).

  • try-runtime :: Done (Trace prints not working - looks like substrate cli issue)

R.Rajeshkumar and others added 25 commits July 12, 2022 18:22
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
Signed-off-by: R.Rajeshkumar <rajesh@nodle.com>
@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #646 (315f22c) into master (d0c20b0) will decrease coverage by 0.00%.
The diff coverage is 48.48%.

@@            Coverage Diff             @@
##           master     #646      +/-   ##
==========================================
- Coverage   89.73%   89.72%   -0.01%     
==========================================
  Files          33       33              
  Lines        6232     6231       -1     
==========================================
- Hits         5592     5591       -1     
  Misses        640      640              
Impacted Files Coverage Δ
node/src/chain_spec.rs 0.00% <ø> (ø)
node/src/cli.rs 0.00% <0.00%> (ø)
node/src/rpc.rs 0.00% <0.00%> (ø)
node/src/service.rs 0.00% <0.00%> (ø)
pallets/grants/src/benchmarking.rs 100.00% <ø> (ø)
pallets/grants/src/lib.rs 62.96% <ø> (ø)
runtimes/eden/src/pallets_parachain.rs 0.00% <ø> (ø)
runtimes/eden/src/pallets_system.rs 0.00% <ø> (ø)
runtimes/eden/src/pallets_util.rs 0.00% <ø> (ø)
runtimes/eden/src/version.rs 0.00% <ø> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@rajesh-nodle
Copy link
Contributor Author

rajesh-nodle commented Jul 28, 2022

Parachain runtime Upgrade status ...

Cfg1

  • nodle-chain ver (v2.0.21) Host
  • runtime wasm blob from v0.9.26

Failed, looks like migrated v0.9.26 runtime is looking for Host
function which is not part of (v2.0.21) host client.

2022-07-28 15:26:54 [Parachain] 🔖 Pre-sealed block for proposal at 117. Hash now 0xaeb69013dbbdcd713f20d4ce7db77cfb77cd03086e63fbe12f05e104a19cb622, previously 0x15c6c00fc049e160fc9c6ed0ea7c21076809c310eb8e2f9ba4c05be77a1c45ac.    
2022-07-28 15:26:54 [Parachain] ✨ Imported #117 (0xaeb6…b622)    
2022-07-28 15:26:54 [Parachain] PoV size { header: 0.1796875kb, extrinsics: 2.857421875kb, storage_proof: 1224.09765625kb }
2022-07-28 15:26:54 [Parachain] Compressed PoV size: 1227.177734375kb
2022-07-28 15:26:55 [Parachain] Cannot create a runtime error=Other("runtime requires function imports which are not present on the host: 'env:ext_benchmarking_read_write_count_version_1', 'env:ext_benchmarking_set_whitelist_version_1', 'env:ext_benchmarking_reset_read_write_count_version_1', 'env:ext_benchmarking_wipe_db_version_1', 'env:ext_benchmarking_add_to_whitelist_version_1', 'env:ext_benchmarking_get_read_and_written_keys_version_1', 'env:ext_benchmarking_current_time_version_1', 'env:ext_benchmarking_proof_size_version_1', 'env:ext_benchmarking_commit_db_version_1'")
2022-07-28 15:26:55 [Parachain] Failed to collect collation info. error=Application(VersionInvalid("runtime requires function imports which are not present on the host: 'env:ext_benchmarking_read_write_count_version_1', 'env:ext_benchmarking_set_whitelist_version_1', 'env:ext_benchmarking_reset_read_write_count_version_1', 'env:ext_benchmarking_wipe_db_version_1', 'env:ext_benchmarking_add_to_whitelist_version_1', 'env:ext_benchmarking_get_read_and_written_keys_version_1', 'env:ext_benchmarking_current_time_version_1', 'env:ext_benchmarking_proof_size_version_1', 'env:ext_benchmarking_commit_db_version_1'"))
2022-07-28 15:26:55 [Parachain] 💤 Idle (4 peers), best: #116 (0xf151…edd3), finalized #116 (0xf151…edd3), ⬇ 0.1kiB/s ⬆ 0.2kiB/s    
2022-07-28 15:26:55 [Relaychain] 💤 Idle (6 peers), best: #341 (0xae90…b415), finalized #338 (0xf1c7…e7f4), ⬇ 4.1kiB/s ⬆ 2.5kiB/s    
2022-07-28 15:27:00 [Relaychain] ✨ Imported #342 (0x160d…2af4)    
2022-07-28 15:27:00 [Parachain] Starting collation. relay_parent=0x160d2d3a82246abf263f0470d44b1a95d9965f3e5088f41c00ae46a7f08e2af4 at=0xf151cef5235351080175f68d4b416b245fb607f99cf435e74338032fca48edd3
2022-07-28 15:27:00 [Parachain] 💤 Idle (4 peers), best: #116 (0xf151…edd3), finalized #116 (0xf151…edd3), ⬇ 0 ⬆ 0    
2022-07-28 15:27:00 [Relaychain] 💤 Idle (6 peers), best: #342 (0x160d…2af4), finalized #339 (0xf4a6…03d7), ⬇ 1.8kiB/s ⬆ 2.0kiB/s    

Cfg2

  • nodle-chain ver v0.9.26 Host
  • runtime wasm blob from v0.9.26

Runtime upgrade looks OK

2022-07-28 17:49:36.708  INFO tokio-runtime-worker substrate: 💤 Idle (4 peers), best: #24 (0xfd53…0282), finalized #22 (0xd64e…fbca), ⬇ 74 B/s ⬆ 74 B/s    
2022-07-28 17:49:41.675  INFO tokio-runtime-worker substrate: 💤 Idle (6 peers), best: #112 (0xfe36…eec4), finalized #110 (0xec94…8df8), ⬇ 1.4kiB/s ⬆ 1.4kiB/s    
2022-07-28 17:49:41.708  INFO tokio-runtime-worker substrate: 💤 Idle (4 peers), best: #24 (0xfd53…0282), finalized #23 (0x0be7…1e63), ⬇ 0.1kiB/s ⬆ 0.2kiB/s    
2022-07-28 17:49:42.015  INFO tokio-runtime-worker substrate: ✨ Imported #113 (0x9545…e7ef)    
2022-07-28 17:49:42.028  INFO tokio-runtime-worker cumulus-collator: Starting collation. relay_parent=0x954559cdbb321d01407b744f4645c6e0f77ebc741836561df0de89ba035ae7ef at=0x820a006d57bf91b4eafb93b4fe11b0ff3d00636d8686564d37bcdf719ad312e7
2022-07-28 17:49:42.030  INFO tokio-runtime-worker substrate: ✨ Imported #113 (0x8645…c147)    
2022-07-28 17:49:42.031  INFO tokio-runtime-worker cumulus-collator: Starting collation. relay_parent=0x864538bf71006c051e09e4ffab13c352ce7c2e617d9c645179429d4c244dc147 at=0x820a006d57bf91b4eafb93b4fe11b0ff3d00636d8686564d37bcdf719ad312e7
2022-07-28 17:49:43.676  INFO tokio-runtime-worker sc_basic_authorship::basic_authorship: 🙌 Starting consensus session on top of parent 0x820a006d57bf91b4eafb93b4fe11b0ff3d00636d8686564d37bcdf719ad312e7    
2022-07-28 17:49:43.676  INFO tokio-runtime-worker aura: ⌛️ Discarding proposal for slot 138250898; block production took too long    
2022-07-28 17:49:43.676  INFO tokio-runtime-worker sc_basic_authorship::basic_authorship: 🙌 Starting consensus session on top of parent 0x820a006d57bf91b4eafb93b4fe11b0ff3d00636d8686564d37bcdf719ad312e7    
2022-07-28 17:49:43.676  INFO tokio-runtime-worker runtime::frame-support: ✅ no migration for System    
2022-07-28 17:49:43.676  INFO tokio-runtime-worker runtime::frame-support: ✅ no migration for Timestamp    
2022-07-28 17:49:43.676  INFO tokio-runtime-worker runtime::frame-support: ✅ no migration for Balances    
2022-07-28 17:49:43.676  INFO tokio-runtime-worker runtime::frame-support: ✅ no migration for TransactionPayment    
2022-07-28 17:49:43.676  INFO tokio-runtime-worker runtime::frame-support: ✅ no migration for RandomnessCollectiveFlip    
2022-07-28 17:49:43.676  INFO tokio-runtime-worker runtime::frame-support: ✅ no migration for Scheduler    
2022-07-28 17:49:43.676  INFO tokio-runtime-worker runtime::frame-support: ✅ no migration for CompanyReserve    
2022-07-28 17:49:43.676  INFO tokio-runtime-worker runtime::frame-support: ✅ no migration for InternationalReserve    
2022-07-28 17:49:43.676  INFO tokio-runtime-worker runtime::frame-support: ✅ no migration for UsaReserve    
2022-07-28 17:49:43.676  INFO tokio-runtime-worker runtime::frame-support: ✅ no migration for System    
2022-07-28 17:49:43.676  INFO tokio-runtime-worker runtime::frame-support: ⚠️ Vesting declares internal migrations (which *might* execute). On-chain `StorageVersion(0)` vs current storage version `StorageVersion(0)`    
2022-07-28 17:49:43.676  INFO tokio-runtime-worker runtime::frame-support: ✅ no migration for Timestamp    
2022-07-28 17:49:43.676  INFO tokio-runtime-worker pallet_grants::migrations::v1: on_runtime_upgrade[30]=> Running migration with current storage version <wasm:stripped> / onchain <wasm:stripped>    
2022-07-28 17:49:43.676  INFO tokio-runtime-worker runtime::frame-support: ✅ no migration for Balances    
2022-07-28 17:49:43.677  INFO tokio-runtime-worker runtime::frame-support: ✅ no migration for TransactionPayment    
2022-07-28 17:49:43.677  INFO tokio-runtime-worker runtime::frame-support: ✅ no migration for RandomnessCollectiveFlip    
2022-07-28 17:49:43.677  INFO tokio-runtime-worker runtime::frame-support: ✅ no migration for Scheduler    
2022-07-28 17:49:43.677  INFO tokio-runtime-worker runtime::frame-support: ✅ no migration for CompanyReserve    
2022-07-28 17:49:43.677  INFO tokio-runtime-worker runtime::frame-support: ✅ no migration for InternationalReserve    
2022-07-28 17:49:43.677 ERROR tokio-runtime-worker pallet_grants::migrations::v1: on_runtime_upgrade interrupted, Storage [VestingSchedules] is empty    
2022-07-28 17:49:43.677  INFO tokio-runtime-worker runtime::frame-support: ✅ no migration for UsaReserve    
2022-07-28 17:49:43.677  INFO tokio-runtime-worker runtime::frame-support: ⚠️ Vesting declares internal migrations (which *might* execute). On-chain `StorageVersion(0)` vs current storage version `StorageVersion(0)`    
2022-07-28 17:49:43.677  INFO tokio-runtime-worker pallet_grants::migrations::v1: on_runtime_upgrade[30]=> Running migration with current storage version <wasm:stripped> / onchain <wasm:stripped>    
2022-07-28 17:49:43.677  INFO tokio-runtime-worker runtime::frame-support: ✅ no migration for Mandate    
2022-07-28 17:49:43.677 ERROR tokio-runtime-worker pallet_grants::migrations::v1: on_runtime_upgrade interrupted, Storage [VestingSchedules] is empty    
2022-07-28 17:49:43.677  INFO tokio-runtime-worker runtime::frame-support: ✅ no migration for TechnicalCommittee    
2022-07-28 17:49:43.677  INFO tokio-runtime-worker runtime::frame-support: ✅ no migration for TechnicalMembership    
2022-07-28 17:49:43.677  INFO tokio-runtime-worker runtime::frame-support: ✅ no migration for Authorship    
2022-07-28 17:49:43.677  INFO tokio-runtime-worker runtime::frame-support: ✅ no migration for ValidatorsSet    
2022-07-28 17:49:43.677  INFO tokio-runtime-worker runtime::frame-support: ✅ no migration for Mandate    
2022-07-28 17:49:43.677  INFO tokio-runtime-worker runtime::frame-support: ✅ no migration for TechnicalCommittee    
2022-07-28 17:49:43.677  INFO tokio-runtime-worker runtime::frame-support: ✅ no migration for TechnicalMembership    
2022-07-28 17:49:43.677  INFO tokio-runtime-worker runtime::frame-support: ✅ no migration for Authorship    
2022-07-28 17:49:43.677  INFO tokio-runtime-worker runtime::frame-support: ⚠️ Poa declares internal migrations (which *might* execute). On-chain `StorageVersion(0)` vs current storage version `StorageVersion(0)`    
2022-07-28 17:49:43.677  INFO tokio-runtime-worker runtime::frame-support: ✅ no migration for ValidatorsSet    
2022-07-28 17:49:43.677  INFO tokio-runtime-worker pallet_poa::migrations::v1: on_runtime_upgrade[26]=> Running migration with current storage version <wasm:stripped> / onchain <wasm:stripped>    
2022-07-28 17:49:43.677  INFO tokio-runtime-worker runtime::frame-support: ⚠️ Poa declares internal migrations (which *might* execute). On-chain `StorageVersion(0)` vs current storage version `StorageVersion(0)`    
2022-07-28 17:49:43.677  INFO tokio-runtime-worker pallet_poa::migrations::v1: on_runtime_upgrade[26]=> Running migration with current storage version <wasm:stripped> / onchain <wasm:stripped>    
2022-07-28 17:49:43.677  INFO tokio-runtime-worker pallet_poa::migrations::v1: on_runtime_upgrade[41]=> Clear Result loops[0], backend[0]    
2022-07-28 17:49:43.677  INFO tokio-runtime-worker pallet_poa::migrations::v1: on_runtime_upgrade[48]=> Removed Validators, Migrated to storage version <wasm:stripped>    
2022-07-28 17:49:43.677  INFO tokio-runtime-worker pallet_poa::migrations::v1: on_runtime_upgrade[41]=> Clear Result loops[0], backend[0]    
2022-07-28 17:49:43.677  INFO tokio-runtime-worker runtime::frame-support: ✅ no migration for Session    
2022-07-28 17:49:43.677  INFO tokio-runtime-worker runtime::frame-support: ✅ no migration for Aura    
2022-07-28 17:49:43.677  INFO tokio-runtime-worker pallet_poa::migrations::v1: on_runtime_upgrade[48]=> Removed Validators, Migrated to storage version <wasm:stripped>    
2022-07-28 17:49:43.677  INFO tokio-runtime-worker runtime::frame-support: ✅ no migration for 

@rajesh-nodle rajesh-nodle requested a review from a team July 28, 2022 11:31
@simonsso
Copy link
Collaborator

Is everything committed to this branch?

It did not build on my machine:

simson@tama:~/nodle/chain$ cargo build --release
    Updating git repository `https://github.com/paritytech/substrate`
   Compiling librocksdb-sys v0.6.1+6.28.2
   Compiling zstd-safe v5.0.2+zstd.1.5.2
   Compiling flate2 v1.0.24
   Compiling lz4 v1.23.3
   Compiling expander v0.0.4
   Compiling addr2line v0.17.0
   Compiling ss58-registry v1.25.0
   Compiling wasmtime-types v0.38.3
   Compiling wasmtime-jit-debug v0.38.3
   Compiling frame-support-procedural-tools v4.0.0-dev (https://github.com/paritytech/substrate?branch=polkadot-v0.9.20#563f4820)
   Compiling sp-api-proc-macro v4.0.0-dev (https://github.com/paritytech/substrate?branch=polkadot-v0.9.20#563f4820)
   Compiling cumulus-pallet-parachain-system-proc-macro v0.1.0 (https://github.com/paritytech/cumulus?branch=polkadot-v0.9.26#e43b8b87)
   Compiling cranelift-codegen v0.85.3
   Compiling prost-build v0.10.4
   Compiling snow v0.9.0
   Compiling trust-dns-resolver v0.21.2
error[E0603]: module `group` is private
   --> /home/simson/.cargo/git/checkouts/substrate-7e08433d4c370a21/563f482/frame/support/procedural/tools/src/syn_ext.rs:50:53
    |
50  |                 let syn::group::$name { token, content } = syn::group::$parse(input)?;
    |                                                                 ^^^^^ private module
    |
note: the module `group` is defined here
   --> /home/simson/.cargo/registry/src/github.com-1ecc6299db9ec823/syn-1.0.98/src/lib.rs:304:1
    |
304 | mod group;
    | ^^^^^^^^^

error[E0603]: module `group` is private
   --> /home/simson/.cargo/git/checkouts/substrate-7e08433d4c370a21/563f482/frame/support/procedural/tools/src/syn_ext.rs:50:14
    |
50  |                 let syn::group::$name { token, content } = syn::group::$parse(input)?;
    |                          ^^^^^ private module
    |
note: the module `group` is defined here
   --> /home/simson/.cargo/registry/src/github.com-1ecc6299db9ec823/syn-1.0.98/src/lib.rs:304:1
    |
304 | mod group;
    | ^^^^^^^^^

For more information about this error, try `rustc --explain E0603`.
   Compiling sp-core-hashing-proc-macro v5.0.0 (https://github.com/paritytech/substrate?branch=polkadot-v0.9.26#e8a7d161)
error: could not compile `frame-support-procedural-tools` due to 2 previous errors
warning: build failed, waiting for other jobs to finish...

@rajesh-nodle
Copy link
Contributor Author

  • Looks CI Build is OK, So no issues with integrity of commits,

  • Good to verify the toolchain default, CI build uses nightly as default,
    and I am using the same on my local dev machine.

  • And as worst case option, better to make fresh checkout of the repo, and trigger fresh build.

@simonsso
Copy link
Collaborator

  • Looks CI Build is OK, So no issues with integrity of commits,

I looked at CI status and saw only the red markers from code coverage.

node/src/chain_spec.rs Show resolved Hide resolved
node/src/rpc.rs Outdated Show resolved Hide resolved
Co-authored-by: Fredrik Simonsson <fredrik@nodle.com>
R.Rajeshkumar and others added 5 commits August 1, 2022 12:54
@aliXsed aliXsed merged commit a8aa73b into master Aug 2, 2022
@aliXsed aliXsed deleted the shamb0/upgrade-polkadot-v0.9.26 branch August 2, 2022 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade the chain with Polkadot v0.9.25
3 participants