Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renounce privileges #662

Merged
merged 7 commits into from Aug 24, 2022
Merged

renounce privileges #662

merged 7 commits into from Aug 24, 2022

Conversation

ETeissonniere
Copy link
Member

Modify the grants pallet so that the CancelOrigin can renounce its
privileges to call cancel_all_vesting_schedules for a given account.

@ETeissonniere ETeissonniere marked this pull request as ready for review August 22, 2022 18:07
@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #662 (3e1f5e6) into master (643b448) will increase coverage by 0.14%.
The diff coverage is 96.77%.

@@            Coverage Diff             @@
##           master     #662      +/-   ##
==========================================
+ Coverage   89.64%   89.79%   +0.14%     
==========================================
  Files          33       33              
  Lines        6169     6191      +22     
==========================================
+ Hits         5530     5559      +29     
+ Misses        639      632       -7     
Impacted Files Coverage Δ
runtimes/eden/src/pallets_util.rs 0.00% <ø> (ø)
runtimes/eden/src/version.rs 0.00% <ø> (ø)
pallets/grants/src/lib.rs 68.46% <90.00%> (+5.50%) ⬆️
pallets/grants/src/benchmarking.rs 100.00% <100.00%> (ø)
pallets/grants/src/tests.rs 99.25% <100.00%> (+0.04%) ⬆️
node/src/service.rs 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aliXsed
Copy link
Contributor

aliXsed commented Aug 23, 2022

This feature could be a lot more useful if the origin of the root level operations which goes through pallet-mandate was configured to be a different collection of wallets or at least a higher threshold of yes (e.g. 3/4 vs 1/2) was required for mandating an upgrade. However with the current number of technical committee members, A 3/4th threshold would allow a mere two wallets to obstruct any future amendments which doesn't seem to be safe. So I'm leaning towards yes to this feature as it is and accept its limitation. With an improved government structure later, we can make sure that different privileged operations have different origins, when it makes them more reasonable or safer.

pallets/grants/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@aliXsed aliXsed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ETeissonniere ETeissonniere merged commit 5aa5152 into master Aug 24, 2022
@ETeissonniere ETeissonniere deleted the feat/renounce-privileges branch August 24, 2022 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants