New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
renounce privileges #662
renounce privileges #662
Conversation
Codecov Report
@@ Coverage Diff @@
## master #662 +/- ##
==========================================
+ Coverage 89.64% 89.79% +0.14%
==========================================
Files 33 33
Lines 6169 6191 +22
==========================================
+ Hits 5530 5559 +29
+ Misses 639 632 -7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This feature could be a lot more useful if the origin of the root level operations which goes through pallet-mandate was configured to be a different collection of wallets or at least a higher threshold of yes (e.g. 3/4 vs 1/2) was required for mandating an upgrade. However with the current number of technical committee members, A 3/4th threshold would allow a mere two wallets to obstruct any future amendments which doesn't seem to be safe. So I'm leaning towards yes to this feature as it is and accept its limitation. With an improved government structure later, we can make sure that different privileged operations have different origins, when it makes them more reasonable or safer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Modify the
grants
pallet so that theCancelOrigin
can renounce itsprivileges to call
cancel_all_vesting_schedules
for a given account.