rpc system.properties will return ss58Format #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change dose not bite for But will bite when running |
simonsso
force-pushed
the
fredrik/iso_163_ss58format
branch
from
f01c793
to
41565d6
Compare
Codecov Report
@@ Coverage Diff @@
## master #669 +/- ##
=======================================
Coverage 89.96% 89.96%
=======================================
Files 33 33
Lines 6181 6181
=======================================
Hits 5561 5561
Misses 620 620 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Full rebuild and the change will bite. |
ETeissonniere
approved these changes
Sep 13, 2022
secretfader
reviewed
Sep 13, 2022
| "tokenSymbol": "notNODL" | ||
| "tokenSymbol": "notNODL", | ||
| "ss58Format": 37 | ||
|
|
There was a problem hiding this comment.
Looks good to me. If there's a blank line here (as it appears) we might want to remove it, and consider adding a JSON formatter in the future.
secretfader
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close NodleCode/chain-workspace#163