Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to polkadot v0.9.29 #673

Merged
merged 24 commits into from Oct 19, 2022
Merged

Upgrade to polkadot v0.9.29 #673

merged 24 commits into from Oct 19, 2022

Conversation

simonsso
Copy link
Collaborator

@simonsso simonsso commented Sep 29, 2022

  • Verify merges
  • Upgrade spec_version in runtimes/eden/src/version.rs
  • cargo build --release
  • cargo test
  • Benchmarks compiles
  • Weights update or ignored
  • try-runtime
  • Run local test-net
  • File tickets if metadata changed
  • Clean up debug commits

@@ -34,7 +34,7 @@ use frame_support::{
BoundedVec,
};
use sp_runtime::{
traits::{AtLeast32Bit, BlockNumberProvider, CheckedAdd, Saturating, StaticLookup, Zero},
traits::{AtLeast32Bit, BlockNumberProvider, CheckedAdd, StaticLookup, Zero, Saturating},
Copy link
Contributor

@aliXsed aliXsed Oct 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you formatted the code?

aliXsed
aliXsed previously approved these changes Oct 12, 2022
Copy link
Contributor

@aliXsed aliXsed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

@aliXsed aliXsed self-requested a review October 12, 2022 21:41
@codecov
Copy link

codecov bot commented Oct 15, 2022

Codecov Report

Merging #673 (9ffd8e4) into master (90f1f98) will decrease coverage by 9.18%.
The diff coverage is 0.52%.

@@            Coverage Diff             @@
##           master     #673      +/-   ##
==========================================
- Coverage   89.43%   80.24%   -9.19%     
==========================================
  Files          33       41       +8     
  Lines        6609     7367     +758     
==========================================
+ Hits         5911     5912       +1     
- Misses        698     1455     +757     
Impacted Files Coverage Δ
node/src/service.rs 0.00% <ø> (ø)
pallets/mandate/src/lib.rs 0.00% <0.00%> (ø)
pallets/reserve/src/lib.rs 45.94% <0.00%> (ø)
runtimes/eden/src/constants.rs 87.50% <ø> (ø)
runtimes/eden/src/lib.rs 4.30% <0.00%> (-0.10%) ⬇️
runtimes/eden/src/pallets_parachain.rs 0.00% <0.00%> (ø)
runtimes/eden/src/version.rs 0.00% <ø> (ø)
runtimes/eden/src/weights/frame_system.rs 0.00% <0.00%> (ø)
runtimes/eden/src/weights/pallet_balances.rs 0.00% <0.00%> (ø)
runtimes/eden/src/weights/pallet_multisig.rs 0.00% <0.00%> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@simonsso
Copy link
Collaborator Author

simonsso commented Oct 19, 2022

  • Ready for review now, the commit messages in this PR are terrible so some editing of the commit message is required when we squash the commits on intake.
  • Added all the generated weights files, I think this is the way to use them.
  • There are a ton of clippy warnings from the weights converting from u64 to u64, they originate from the template file but this is subject to change again soon when 2D weights are introduced upstream.
  • There are no change in test coverage as this is only a version upgrade
  • There are two unrelated changes to weighs the system one is from running benchmarks and one is upstream chaining the weight system

@secretfader
Copy link

Looks good to me. In my opinion, we should consider updating the weights template to remove the unnecessary cast that Clippy is complaining about, but that's for another time.

@simonsso simonsso merged commit 863b8a2 into master Oct 19, 2022
@simonsso simonsso deleted the fredrik/polkadot_v0.9.29 branch October 19, 2022 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants