New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to polkadot v0.9.29 #673
Conversation
simonsso
commented
Sep 29, 2022
•
edited
edited
- Verify merges
- Upgrade spec_version in runtimes/eden/src/version.rs
- cargo build --release
- cargo test
- Benchmarks compiles
- Weights update or ignored
- try-runtime
- Run local test-net
- File tickets if metadata changed
- Clean up debug commits
44e38a3
to
3dff714
Compare
3dff714
to
73ea30c
Compare
pallets/grants/src/lib.rs
Outdated
@@ -34,7 +34,7 @@ use frame_support::{ | |||
BoundedVec, | |||
}; | |||
use sp_runtime::{ | |||
traits::{AtLeast32Bit, BlockNumberProvider, CheckedAdd, Saturating, StaticLookup, Zero}, | |||
traits::{AtLeast32Bit, BlockNumberProvider, CheckedAdd, StaticLookup, Zero, Saturating}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you formatted the code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT!
… into fredrik/polkadot_v0.9.29
… into fredrik/polkadot_v0.9.29
Codecov Report
@@ Coverage Diff @@
## master #673 +/- ##
==========================================
- Coverage 89.43% 80.24% -9.19%
==========================================
Files 33 41 +8
Lines 6609 7367 +758
==========================================
+ Hits 5911 5912 +1
- Misses 698 1455 +757
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Update spec version Remove clippy warning
|
Looks good to me. In my opinion, we should consider updating the weights template to remove the unnecessary cast that Clippy is complaining about, but that's for another time. |