Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace POA with Collator selection #679

Merged
merged 9 commits into from Nov 8, 2022
Merged

Replace POA with Collator selection #679

merged 9 commits into from Nov 8, 2022

Conversation

aliXsed
Copy link
Contributor

@aliXsed aliXsed commented Oct 31, 2022

Must:

  • Add pallet_collator_selection
  • Remove pallet_poa
  • Set Nodle collators as invulnerables in pallet_collator_selction. This is so the Nodle collators stay selected the chain's governance votes for removing them. The down side is when Nodle collators are unstable and not creating blocks, they wouldn't be kicked out. As a result the missed turns continue to show up as repeating extra delays in block creation. Fortunately, this hasn't been an issue with Nodle's main-net is only observed on the test-net.
  • Pay the 80% share of the fees that now goes to the block author to the stake pot held by pallet-collator-selection so this pallet compensates the authors based on its own logic.
  • Fix try-runtime panicked at 'Empty validator set for session 0 in genesis block!',
  • Migrate ValidatorsSet storage, Remove Poa strorage
  • Test the change locally
  • Test an upgrade from the current runtime to this new runtime locally and check the block creation proceeds with the previous set of the collators.
  • Update weights

@aliXsed aliXsed requested a review from simonsso October 31, 2022 05:01
CollatorSelection is the new session manager and should be built before Session.
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #679 (601b656) into master (863b8a2) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #679      +/-   ##
==========================================
+ Coverage   80.24%   80.27%   +0.02%     
==========================================
  Files          41       39       -2     
  Lines        7367     7326      -41     
==========================================
- Hits         5912     5881      -31     
+ Misses       1455     1445      -10     
Impacted Files Coverage Δ
node/src/chain_spec.rs 0.00% <ø> (ø)
runtimes/eden/src/implementations.rs 0.00% <0.00%> (ø)
runtimes/eden/src/lib.rs 4.21% <0.00%> (-0.10%) ⬇️
runtimes/eden/src/pallets_consensus.rs 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Move relevant storage entries from ValidatorsSet to CollatorSelection
@aliXsed aliXsed marked this pull request as ready for review November 3, 2022 03:36
runtimes/eden/src/lib.rs Show resolved Hide resolved
runtimes/eden/src/migrations.rs Outdated Show resolved Hide resolved
runtimes/eden/src/migrations.rs Outdated Show resolved Hide resolved
runtimes/eden/src/migrations.rs Show resolved Hide resolved
@aliXsed aliXsed merged commit 2d49b97 into master Nov 8, 2022
@aliXsed aliXsed deleted the collator-selection branch November 8, 2022 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants