Run all CI on 8 cores #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #712 +/- ##
=======================================
Coverage 78.20% 78.20%
=======================================
Files 43 43
Lines 7580 7580
=======================================
Hits 5928 5928
Misses 1652 1652 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@aliXsed I think we should change the executors to 8 cores for cost savings. Executors are prices linear and performance gains are always under 100% for doubling the cores. However at 8 core all builds are under 1 hour. |
simonsso
commented
Feb 27, 2023
| @@ -36,7 +36,7 @@ jobs: | |||
| toolchain: ${{ env.nightly }} | |||
|
|
|||
| tests: | |||
| runs-on: ubuntu-latest-16-cores | |||
| runs-on: ubuntu-latest-8-cores | |||
There was a problem hiding this comment.
This is the slowest, 16 cores will push this down from 58 to 40 minutes
.github/workflows/ci.yml
Outdated
| @@ -90,7 +90,7 @@ jobs: | |||
| output.txt | |||
|
|
|||
| tarpaulin: | |||
| runs-on: ubuntu-latest-16-cores | |||
| runs-on: ubuntu-latest-8-cores | |||
There was a problem hiding this comment.
This could run fine on 4 cores too.
simonsso
commented
Feb 28, 2023
aliXsed
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.