Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XCM] Benchmarks #716

Merged
merged 22 commits into from Mar 15, 2023
Merged

[XCM] Benchmarks #716

merged 22 commits into from Mar 15, 2023

Conversation

Hounsette
Copy link
Contributor

@Hounsette Hounsette commented Mar 8, 2023

Adding benchmarks for the pallet xcm.

runtimes/eden/src/lib.rs Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #716 (dbf4c2b) into master (e4ab801) will decrease coverage by 1.92%.
The diff coverage is 0.73%.

@@            Coverage Diff             @@
##           master     #716      +/-   ##
==========================================
- Coverage   77.07%   75.16%   -1.92%     
==========================================
  Files          44       47       +3     
  Lines       11755    12054     +299     
==========================================
  Hits         9060     9060              
- Misses       2695     2994     +299     
Impacted Files Coverage Δ
pallets/grants/src/weights.rs 0.00% <0.00%> (ø)
pallets/reserve/src/weights.rs 0.00% <0.00%> (ø)
pallets/staking/src/mock.rs 92.68% <0.00%> (ø)
runtimes/eden/src/lib.rs 2.65% <0.00%> (-0.06%) ⬇️
runtimes/eden/src/weights/frame_system.rs 0.00% <0.00%> (ø)
runtimes/eden/src/weights/mod.rs 0.00% <0.00%> (ø)
runtimes/eden/src/weights/pallet_balances.rs 0.00% <0.00%> (ø)
...imes/eden/src/weights/pallet_collator_selection.rs 0.00% <0.00%> (ø)
runtimes/eden/src/weights/pallet_contracts.rs 0.00% <0.00%> (ø)
runtimes/eden/src/weights/pallet_membership.rs 0.00% <0.00%> (ø)
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

runtimes/eden/src/lib.rs Outdated Show resolved Hide resolved
runtimes/eden/src/lib.rs Outdated Show resolved Hide resolved
runtimes/eden/src/lib.rs Outdated Show resolved Hide resolved
runtimes/eden/src/lib.rs Outdated Show resolved Hide resolved
runtimes/eden/src/lib.rs Outdated Show resolved Hide resolved
runtimes/eden/src/lib.rs Outdated Show resolved Hide resolved
runtimes/eden/src/lib.rs Outdated Show resolved Hide resolved
runtimes/eden/src/lib.rs Outdated Show resolved Hide resolved
@aliXsed
Copy link
Contributor

aliXsed commented Mar 14, 2023

@Hounsette we need to change the Weigher in the xcm_config.rs to use WeightInfoBounds instead of FixedWeightBounds. Have a look at KusamaXcmWeight as an example and the way it has used the results of the benchmarking from both the generic and the fungible benchmarks.

.maintain/xcm.hbs Outdated Show resolved Hide resolved
.maintain/xcm.hbs Outdated Show resolved Hide resolved
.maintain/xcm.hbs Outdated Show resolved Hide resolved
@simonsso
Copy link
Collaborator

simonsso commented Mar 15, 2023

@Hounsette this rebase I did was not successful, please force push your last commit again.

@simonsso simonsso mentioned this pull request Mar 15, 2023
@aliXsed aliXsed merged commit 4b69e0d into master Mar 15, 2023
@aliXsed aliXsed deleted the xcm-benchmark branch March 15, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants