Transaction Sponsorship #767

aliXsed · 2023-08-03T05:28:04Z

Add update for user limits and pot limits
Benchmark using the standard machine

…st of the newly registered

…ance notion

codecov · 2023-08-04T01:23:13Z

Codecov Report

Patch coverage: 82.52% and project coverage change: +8.27% 🎉

Comparison is base (31483cf) 64.87% compared to head (4b1d0d9) 73.14%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #767      +/-   ##
==========================================
+ Coverage   64.87%   73.14%   +8.27%     
==========================================
  Files          40       47       +7     
  Lines        6072     8981    +2909     
==========================================
+ Hits         3939     6569    +2630     
- Misses       2133     2412     +279

Files Changed	Coverage Δ
pallets/grants/src/weights.rs	`0.00% <0.00%> (ø)`
pallets/uniques/src/weights.rs	`0.00% <0.00%> (ø)`
runtimes/eden/src/lib.rs	`2.80% <0.00%> (-0.03%)`	⬇️
runtimes/eden/src/pallets_system.rs	`0.00% <0.00%> (ø)`
runtimes/eden/src/pallets_util.rs	`0.00% <0.00%> (ø)`
runtimes/eden/src/weights/frame_system.rs	`0.00% <0.00%> (ø)`
runtimes/eden/src/weights/pallet_balances.rs	`0.00% <0.00%> (ø)`
...imes/eden/src/weights/pallet_collator_selection.rs	`0.00% <0.00%> (ø)`
runtimes/eden/src/weights/pallet_membership.rs	`0.00% <0.00%> (ø)`
runtimes/eden/src/weights/pallet_multisig.rs	`0.00% <0.00%> (ø)`
... and 18 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…y this pallet

…calls And add lots of test

ETeissonniere

Looking good! I left some minor changes and thoughts

pallets/sponsorship/README.md

pallets/sponsorship/src/benchmarking.rs

support/src/lib.rs

support/Cargo.toml

pallets/sponsorship/Cargo.toml

runtimes/eden/src/pallets_util.rs

pallets/sponsorship/src/lib.rs

Co-authored-by: Eliott Teissonniere <10683430+ETeissonniere@users.noreply.github.com>

…quotas

…ree_balance_allows

…ited usefulness compared with the added complexity of correct benchmarking

The benchamrk test for "sponosr_for" extrinsic will come in the next commit

# Conflicts: # runtimes/eden/src/lib.rs # runtimes/eden/src/pallets_util.rs

…chmarking of sponsor_for

…nchmark code

ETeissonniere

lgtm. to be merged once the try-runtime checks pass

aliXsed added 20 commits July 25, 2023 16:20

feat(pallet-sponsorship): add pallet skeleton based on template-pallet

091bf9d

feat(runtime-eden): add pallet_sponsorship to runtime-eden

6bdd327

chore(pallet-sponsorship): add Nodle header to the files

07353a8

feat: add create_pot to pallet-sponsorship

3024002

feat(pallet-sponsorship): add remove_pot extrinsic

6ac56e3

chore(pallet-sponsorship): add doc comments to create_pot remove_pot

d2cbca1

chore(pallet-sponsorship): improve test case names

a154c02

feat(pallet-sponsorship): add register_users

e6b9408

benchmark(pallet-sponsorship): cover register_users

1016bd2

feat(pallet-sponsorship): register_users emit event containing the li…

ebf3062

…st of the newly registered

chore(pallet-sponsorship): improve comment for register_users

912d22b

feat(pallet-sponsorship): add remove_users

e7877a3

feat(pallet-sponsorship): add remove_inactive_users

61188ad

test(pallet-sponsorship): improve current test

fcd4a8e

feat: add sponsor_for call to pallet_sponsorship and reuse LimitedBal…

48d730c

…ance notion

doc(pallet-sponsorship): improve doc comment of sponsor_for

69f576f

doc(pallet-sponsorship): improve doc comment of sponsor_for

f121aa3

fix: package support should be imported with default-features off

926a28a

fix: package support should be imported with default-features off

aadb5ea

ci(pallet-sponsorship): fix lint error and test all-features error

fa1bed3

aliXsed added 2 commits August 7, 2023 11:23

feat(pallet-sponsorship): add account management for users provided b…

be57442

…y this pallet

lint(pallet-sponsorship): remove unnecessary references

02dd108

aliXsed force-pushed the aliX/sponsorship_pallet branch from e5186f5 to 32b0505 Compare August 9, 2023 04:30

feat(pallet-sponsorship): deduct transaction fee from sponsor

0c9ff50

aliXsed force-pushed the aliX/sponsorship_pallet branch from 6a63c5e to 0c9ff50 Compare August 9, 2023 06:11

aliXsed added 2 commits August 10, 2023 17:03

fix(pallet-sponsorship): correct handling of pre- and post- dispatch …

b755ae2

…calls And add lots of test

Merge branch 'master' into aliX/sponsorship_pallet

76a5043

aliXsed marked this pull request as ready for review August 10, 2023 05:05

aliXsed requested a review from Hounsette August 10, 2023 05:07

ETeissonniere requested changes Aug 10, 2023

View reviewed changes

aliXsed and others added 6 commits August 14, 2023 13:28

Update author in support/Cargo.toml

7c06409

Co-authored-by: Eliott Teissonniere <10683430+ETeissonniere@users.noreply.github.com>

Update author in pallets/sponsorship/Cargo.toml

2233246

Co-authored-by: Eliott Teissonniere <10683430+ETeissonniere@users.noreply.github.com>

doc(pallet-sponsorship): add a brief readme

b508961

test(support): Add unit tests for LimitedBalance

062944d

feat(runtime-eden): simplify the sponsorship categories

6d2a370

feat(pallet-sponsorship): make all events follow named structs

0216972

ETeissonniere removed the request for review from Hounsette August 15, 2023 22:50

aliXsed added 18 commits August 16, 2023 14:59

feat(pallet-sponsorship): use LimitedBalance for all fee and reserve …

320385d

…quotas

refactor(pallet-sponsorship): improve naming

d64c48a

fix(pallet-sponsorship): users_pay_back_debts_when_removed_if_their_f…

fc61534

…ree_balance_allows

test(pallet-sponsorship): increase line coverage

8efbaf3

feat(pallet-sponsorship): update_pot_limits

a9ce998

feat(pallet-sponsorship): update_users_limits

a0486bd

feat(pallet-sponsorship): remove remove_inactive_users due to its lim…

74064f7

…ited usefulness compared with the added complexity of correct benchmarking

feat(pallet-sponsorship): add update_sponsorship_type

722b2a3

fix(pallet-sponsorship): correct benchmark for remove_users

78a514d

benchmark: all the pallets using standard machine [WIP]

041c58b

The benchamrk test for "sponosr_for" extrinsic will come in the next commit

benchmark(pallet-sponsorship): add benchmark for sponsor_for

e53002f

benchmark(pallet-sponsorship): update weights

eab2977

Merge branch 'master' into aliX/sponsorship_pallet

57afc85

# Conflicts: # runtimes/eden/src/lib.rs # runtimes/eden/src/pallets_util.rs

test(pallet-sponsorship): allocate a bigger fee pot following the ben…

ba6122b

…chmarking of sponsor_for

clippy(pallet-sponsorship): fix warnings

71121e4

fix(pallet-sponsorship): remove benchmark only extrinsics

2d12d10

benchmark(pallet-sponsorship): update the weights using the latest be…

b4e29b2

…nchmark code

Merge branch 'master' into aliX/sponsorship_pallet

e8964b2

ETeissonniere approved these changes Aug 29, 2023

View reviewed changes

Merge branch 'master' into aliX/sponsorship_pallet

4b1d0d9

ETeissonniere merged commit 042a562 into master Aug 30, 2023
7 checks passed

ETeissonniere deleted the aliX/sponsorship_pallet branch August 30, 2023 02:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Transaction Sponsorship #767

Transaction Sponsorship #767

aliXsed commented Aug 3, 2023 •

edited

codecov bot commented Aug 4, 2023 •

edited

ETeissonniere left a comment

ETeissonniere left a comment

Transaction Sponsorship #767

Transaction Sponsorship #767

Conversation

aliXsed commented Aug 3, 2023 • edited

codecov bot commented Aug 4, 2023 • edited

Codecov Report

ETeissonniere left a comment

Choose a reason for hiding this comment

ETeissonniere left a comment

Choose a reason for hiding this comment

aliXsed commented Aug 3, 2023 •

edited

codecov bot commented Aug 4, 2023 •

edited