Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverse migration for testnet #781

Merged
merged 6 commits into from Sep 12, 2023
Merged

Conversation

simonsso
Copy link
Collaborator

No description provided.

Current spec is 23 no need to go full 25 yet
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.27% 🎉

Comparison is base (f6d5834) 73.14% compared to head (7ac05e4) 73.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #781      +/-   ##
==========================================
+ Coverage   73.14%   73.42%   +0.27%     
==========================================
  Files          47       48       +1     
  Lines        8981     9015      +34     
==========================================
+ Hits         6569     6619      +50     
+ Misses       2412     2396      -16     
Files Changed Coverage Δ
runtimes/eden/src/lib.rs 10.44% <0.00%> (+7.64%) ⬆️
runtimes/eden/src/migrations.rs 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Alex Sedighi <alex@nodle.com>
@simonsso
Copy link
Collaborator Author

simonsso commented Sep 12, 2023

I will ignore the cargo fmt lint warning and merge this as file is to be deleted in next release anyway.

  • Try-runtime for testnet is verified on desktop.
  • Coverage error does not matter for this kind of relase

@simonsso simonsso merged commit 9997ceb into master Sep 12, 2023
5 of 7 checks passed
@simonsso simonsso deleted the iso/reversemigration-for-testnet branch September 12, 2023 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants