Cleanup migrations #823
Merged
Cleanup migrations #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonsso
force-pushed
the
iso/20240206T0947-migration-cleanup
branch
from
ece271c
to
dd0e634
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #823 +/- ##
==========================================
+ Coverage 65.80% 67.21% +1.41%
==========================================
Files 50 49 -1
Lines 11430 11003 -427
==========================================
- Hits 7521 7396 -125
+ Misses 3909 3607 -302 ☔ View full report in Codecov by Sentry. |
aliXsed
reviewed
Feb 9, 2024
|
@simonsso I have reviewed this PR completely and apart from that one comment, happy with the rest of it. If the answer to that comment is yes, feel free to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrations executed on chain (mainnet) for runtime spec 27