updates

[ihadeed]

• removed dependencies
  • made everything a dev dependency to make things simpler
• added NgModule ( closes Ionic 3 Please add a @NgModule annotation Error #25 )
• added .editorconfig file
• removed typings and added @types
• compiling with ngc instead of tsc to produce needed files for AoT compilation
• added tests
• fix linting
• add circleci instructions

I might add more things to this PR .. still testing the library.. these are just the first things I noticed that need changing

[Nodonisko]

Wow! Such a nice PR, I think we should publish this as version 2.0.0

[Nodonisko]

I think this should stay here

[Nodonisko]

It looks really nice, please fix .gitignore and we can merge it :)

[ihadeed]

Will update it soon, just finishing up the tests.

[ihadeed]

Ok @Nodonisko all is done!

I also added CircleCI configuration to the project. You can see a sample build here: https://circleci.com/gh/ihadeed/ionic-cache/1

You just need to sign up there and add your repo so it gets built automatically on pushes/PRs. It's free for open source projects. If you want to use TravisCI instead I can put together a different config file. I personally prefer CircleCI 2.0 since it's much faster. If node_modules is cached, builds take ~17 seconds, see this build for example.

[Nodonisko]

It's really awesome. I will merge it and after I will fix few more issues and we can release.

Thanks very much! I will mention you in readme :)

[ihadeed]

It's worth noting that there's one breaking change. I renamed disableCache to enableCache. I thought it would be more intuitive and straightforward.

So to disable cache you need to call:

this.cache.enableCache(false);

and to re-enable you call:

this.cache.enableCache(true);

[Nodonisko]

Yes, I think so, it was really bad naming.

But best change is tests, it will help a lot.