Quiz selection functionality #57
Conversation
Nodrex
changed the title
# Conflicts: # testomania/src/main/java/com/earth/testomania/technical/presentation/TechnicalTestsScreen.kt # testomania/src/main/java/com/earth/testomania/technical/presentation/ui_parts/QuizUI.kt
testomania/src/main/java/com/earth/testomania/technical/domain/model/SelectedAnswer.kt
Show resolved
Hide resolved
testomania/src/main/java/com/earth/testomania/technical/presentation/QuizViewModel.kt
Outdated
Show resolved
Hide resolved
| fun isCorrectAnswer( | ||
| techQuizWrapper: TechQuizWrapper, | ||
| possibleAnswerKey: String | ||
| ) = techQuizWrapper.quiz.correctAnswers[possibleAnswerKey] ?: false |
There was a problem hiding this comment.
move this method in TechQuiz class
There was a problem hiding this comment.
Well TechQuiz is just a model and should stay that way, but is selected answer correct or not is business logic, so it should be in ViewModel, logic of is correct or not can be changed in the future, like if answers will be differentiated with numbers and not letters, just for example, so yea I think fun isCorrectAnswer should remain in ViewModel
There was a problem hiding this comment.
I'm not agree with you. As I know TechQuiz is an object which has question, possible answers and correct answer, so adding one method for checking correctnes of answers, is more modular and convinient. I'm not asking to add it in dto model, but there should be no problem for adding it in presentation model. I hope that logic for determaining if answer is correct or not is same, there this model is used.
There was a problem hiding this comment.
I believe you mean domain/model/TechQuiz.kt and not presentation layer. am I right? @kdiakonidze
If we do that then we need an interface with a defined method isCorrectAnswer and I think that is a generalization of TechQuiz.kt which I agree with, but we need more conversation on that, meanwhile I think we can leave it in ViewModel
There was a problem hiding this comment.
yes, domain model. If you use isCorrectAnswer method only one place, than ok.
There was a problem hiding this comment.
Yes for now it is only defined in this viewmodel and is used in only one compose function
testomania/src/main/java/com/earth/testomania/technical/presentation/QuizViewModel.kt
Outdated
Show resolved
Hide resolved
| techQuizWrapper.multiSelectionWasDone.value = true | ||
| } | ||
|
|
||
| private fun saveMultiSelectQuizPoint(techQuizWrapper: TechQuizWrapper) { |
There was a problem hiding this comment.
I think this method also can be moved to TechQuiz
There was a problem hiding this comment.
I can say same as in case of isCorrectAnswer function above.
TechQuiz is Model and saveMultiSelectQuizPoint is buisness logic, which can vary in case of different tests
# Conflicts: # testomania/src/main/java/com/earth/testomania/technical/presentation/TechnicalTestsScreen.kt # testomania/src/main/java/com/earth/testomania/technical/presentation/ui_parts/QuizAnswerUI.kt # testomania/src/main/java/com/earth/testomania/technical/presentation/ui_parts/QuizUI.kt
testomania/src/main/java/com/earth/testomania/core/helper/Helper.kt
Outdated
Show resolved
Hide resolved
testomania/src/main/java/com/earth/testomania/technical/domain/model/AnswerKey.kt
Show resolved
Hide resolved
testomania/src/main/java/com/earth/testomania/technical/domain/use_case/GetQuizListUseCase.kt
Outdated
Show resolved
Hide resolved
testomania/src/main/java/com/earth/testomania/technical/presentation/QuizViewModel.kt
Outdated
Show resolved
Hide resolved
testomania/src/main/java/com/earth/testomania/technical/presentation/QuizViewModel.kt
Show resolved
Hide resolved
testomania/src/main/java/com/earth/testomania/technical/presentation/ui_parts/QuizAnswerUI.kt
Outdated
Show resolved
Hide resolved
No description provided.