Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI improvements #65

Merged
merged 11 commits into from
Jun 5, 2022
Merged

UI improvements #65

merged 11 commits into from
Jun 5, 2022

Conversation

shalva97
Copy link
Collaborator

No description provided.

@Nodrex Nodrex self-requested a review May 30, 2022 08:14
@Nodrex Nodrex self-requested a review June 5, 2022 14:28
}

@Composable
private fun Radio(
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this to a separate folder like customUIComponents or something like that in core folder

}

private fun DrawScope.drawRadio(borderWidth: Dp, borderColor: Color, backgroundColor: Color) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this as well in to same folder as previous UI component


private fun tmp() =
if (Random(System.currentTimeMillis()).nextBoolean()) R.drawable.ic_correct else R.drawable.ic_wrong
private fun DrawScope.drawError(strokeColor: Color, shadowColor: Color, alpha: Float) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This as well

@shalva97 shalva97 merged commit 95314c1 into main Jun 5, 2022
@shalva97 shalva97 deleted the ui_improvements branch June 5, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants