Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result screen #84

Merged
merged 58 commits into from
Jul 10, 2022
Merged

Result screen #84

merged 58 commits into from
Jul 10, 2022

Conversation

kdiakonidze
Copy link
Collaborator

result screen with incorrect answers

Nodrex and others added 28 commits May 22, 2022 18:04
# Conflicts:
#	testomania/src/main/java/com/earth/testomania/technical/presentation/TechnicalTestsScreen.kt
#	testomania/src/main/java/com/earth/testomania/technical/presentation/ui_parts/QuizUI.kt
# Conflicts:
#	testomania/src/main/java/com/earth/testomania/technical/presentation/TechnicalTestsScreen.kt
#	testomania/src/main/java/com/earth/testomania/technical/presentation/ui_parts/QuizAnswerUI.kt
#	testomania/src/main/java/com/earth/testomania/technical/presentation/ui_parts/QuizUI.kt
# Conflicts:
#	testomania/src/main/java/com/earth/testomania/core/helper/Helper.kt
#	testomania/src/main/java/com/earth/testomania/technical/domain/model/AnswerKey.kt
#	testomania/src/main/java/com/earth/testomania/technical/presentation/QuizViewModel.kt
#	testomania/src/main/java/com/earth/testomania/technical/presentation/ui_parts/QuizAnswerUI.kt
@Nodrex Nodrex self-requested a review June 19, 2022 09:33
@@ -95,14 +98,15 @@ fun IncorrectAnsweredQuestion(item: IncorrectAnsweredQuestionModel) {
) {
Column(
modifier = Modifier
// .background(Color(0x335c5cbb))
.background(Color(0xfff6f7f9))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move this to resources

@@ -139,6 +143,7 @@ fun IncorrectAnsweredQuestion(item: IncorrectAnsweredQuestionModel) {

}

/*
@Composable
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove comments

@@ -217,8 +223,8 @@ fun MainResultItem(
.fillMaxWidth()
.padding(top = 3.dp)
.height(8.dp),
color = mainColor,
backgroundColor = lightColor
// color = mainColor,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove comments

DeepLink(uriPattern = "testomania://home/result")
]
route = "home/result"
// deepLinks = [
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove comments

val viewModel: QuizViewModel = hiltViewModel()

val data = viewModel.data

val resultData = ResultData("TechnicalTests", 0.3f, false)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move string to resources

@kdiakonidze kdiakonidze merged commit c826621 into main Jul 10, 2022
@kdiakonidze kdiakonidze deleted the result-screen branch July 10, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants