Loading screen #89
Merged
Loading screen #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Nodrex
requested review from
shalva97,
kdiakonidze,
likaGlonti,
nmgalo and
tkhat
kdiakonidze
reviewed
Jul 2, 2022
| Code("code", R.drawable.il_code); | ||
|
|
||
| companion object { | ||
| fun findIllustrationByCategory(category: String) = |
There was a problem hiding this comment.
this fun returns TechCategory not illustration. I think "from" will be enough for this method name.
There was a problem hiding this comment.
You mean findIllustrationFrom(category: String) ? @kdiakonidze
There was a problem hiding this comment.
no, just "from" .from(category: String)
There was a problem hiding this comment.
hmm do not know, do not like just from does not gives information what it does
maybe just findSpecific() ?
@kdiakonidze @shalva97
what do you think guys?
There was a problem hiding this comment.
it returns the class from which it was called, our case TechCategory.
There was a problem hiding this comment.
Yep and i think findSpecific() will be informational name for that kind of function
...a/src/main/java/com/earth/testomania/technical/presentation/ui_parts/CategoryIllustration.kt
Outdated
Show resolved
Hide resolved
testomania/src/main/java/com/earth/testomania/technical/presentation/ui_parts/LoadingScreen.kt
Outdated
Show resolved
Hide resolved
kdiakonidze
reviewed
Jul 2, 2022
...mania/src/main/java/com/earth/testomania/core/presentation/custom/TestomaniaInlineLoading.kt
Show resolved
Hide resolved
shalva97
requested changes
Jul 2, 2022
testomania/src/main/java/com/earth/testomania/technical/presentation/ui_parts/LoadingScreen.kt
Outdated
Show resolved
Hide resolved
testomania/src/main/java/com/earth/testomania/technical/domain/model/TechCategory.kt
Outdated
Show resolved
Hide resolved
shalva97
approved these changes
Jul 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading screen before tests are loaded