Home screen #90
Merged
Home screen #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nodrex
requested review from
shalva97,
nmgalo,
kdiakonidze and
likaGlonti
and removed request for
shalva97
kdiakonidze
reviewed
Jul 3, 2022
testomania/src/main/java/com/earth/testomania/core/Developer.kt
Outdated
Show resolved
Hide resolved
testomania/src/main/java/com/earth/testomania/presentation/AboutBottomSheet.kt
Outdated
Show resolved
Hide resolved
| val viewModel: HomeScreenViewModel = hiltViewModel() | ||
|
|
||
| val contentPadding = 20.dp | ||
| ConstraintLayout( |
There was a problem hiding this comment.
why we need ConstraintLayout here, I think Column will be enough
There was a problem hiding this comment.
Cause the image needs to be centered and above the grid, so Column only has space between and that would not be a good representation, that's why I used ConstraintLayout
|
u need to marge Loading Screen branch into this branch |
yep |
shalva97
reviewed
Jul 10, 2022
testomania/src/main/java/com/earth/testomania/presentation/home/HomeScreen.kt
Outdated
Show resolved
Hide resolved
shalva97
reviewed
Jul 10, 2022
shalva97
requested changes
Jul 10, 2022
kdiakonidze
approved these changes
Jul 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparing home screen for release