Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add field to set publication time #94

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add field to set publication time #94

wants to merge 3 commits into from

Conversation

sonnymilton
Copy link

Closes #74

@Noelierx
Copy link
Owner

Noelierx commented Oct 6, 2020

Hello @Sonny812 Thank you a lot for your pull request, we just need to verify it, but don't worry even if this PR isn't merged at the end of your counter, it will still be a part for the Hacktoberfest and your personal counter!

@Noelierx Noelierx added Hacktoberfest Participate to the Hacktoberfest hacktoberfest-accepted Accepted for Hacktoberfest, will merge later labels Oct 6, 2020
@Noelierx Noelierx added this to the Hacktoberfest 2020 milestone Oct 6, 2020
chypriote
chypriote requested changes Oct 22, 2020
View reviewed changes
Copy link
Collaborator

@chypriote chypriote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So minor formatting problems (use editorconfig to avoid those)

@Noelierx should test wether the feature works correctly

src/Form/Blog/PostType.php Outdated Show resolved Hide resolved
src/Form/DateTimeType.php Outdated Show resolved Hide resolved
src/Form/DateTimeType.php Outdated Show resolved Hide resolved
src/Form/Transformer/DateTimeModelTransformer.php Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chypriote chypriote chypriote approved these changes

Assignees
No one assigned
Labels
Hacktoberfest Participate to the Hacktoberfest hacktoberfest-accepted Accepted for Hacktoberfest, will merge later
Projects
None yet
Milestone
Hacktoberfest 2020
Development

Successfully merging this pull request may close these issues.

As an Editor, I want to schedule article with a time picker.
3 participants
@sonnymilton @Noelierx @chypriote