Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move jQuery and jscolor to assets (#217) #248

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Move jQuery and jscolor to assets (#217) #248

merged 1 commit into from
Jul 22, 2024

Conversation

BafS
Copy link
Contributor

@BafS BafS commented Jul 22, 2024 •
edited
Loading

@BafS BafS mentioned this pull request Jul 22, 2024
Open
@NoiseByNorthwest
Copy link
Owner

LGTM, thanks @BafS !

@NoiseByNorthwest NoiseByNorthwest merged commit 197a3b3 into NoiseByNorthwest:master Jul 22, 2024
24 of 36 checks passed
@BafS
Copy link
Contributor Author

BafS commented Jul 22, 2024

Now that I'm looking at my PR again, shouldn't I be using src="?SPX_UI_URI=/xxx" instead of just src="xxx"? I think it would be better

@NoiseByNorthwest
Copy link
Owner

Yes it should mimic what is done for other js files (such as <script type="module" crossorigin src="?SPX_UI_URI=/js/utils.js"></script>) with the addition of the integrity check.

@BafS BafS mentioned this pull request Jul 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BafS @NoiseByNorthwest