Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dispose in logger #157

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Remove dispose in logger #157

merged 1 commit into from
Nov 4, 2022

Conversation

Vixenka
Copy link
Member

@Vixenka Vixenka commented Nov 4, 2022

Closes #156

@Vixenka Vixenka requested a review from kkard2 November 4, 2022 15:44
@Vixenka Vixenka merged commit 4b97046 into master Nov 4, 2022
@Vixenka Vixenka deleted the feature/156/finalizer-insted-of-dispose-in-logger branch November 4, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkard2 kkard2 kkard2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use finalizer instead of dispose in logger
2 participants
@Vixenka @kkard2