Change thrown exception type in Window's class constructor #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Throw PlatformNotSupportedException instead of the InvalidOperationException in Window's constructor
Vixenka
requested changes
Oct 19, 2023
There was a problem hiding this comment.
Generally thank you for the contributing!
But you do not understand issue well, because you change this on the managed side, but you should change this on this line:
But it still fine, repair this and retry, also remember about C# code style, because you use another :)
This reverts commit 9adfddb as a result of the Code Review.
Vixenka
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw PlatformNotSupportedException instead of the InvalidOperationException in the Window's class constructor as was said in #242