-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/357/use alignment from memory helper #358
base: master
Are you sure you want to change the base?
Fix/357/use alignment from memory helper #358
Conversation
was there a reason for deleting the temp var? probably doesn't matter tho |
I could add that back, thought it should be deleted by the issue's description. Might be worth to add it back in-case these calls are expensive. |
oh you're right, issue sounds like that, but it probably wasn't intended that way. |
remember to use curly braces on the previous line (link). also only now i noticed, you should pull master and branch out from here, currently the history might get goofed up (there are commits from previous prs) |
IDE does that by default need to disable that. Yep noticed that too, for some reason the sync didn't work as expected |
i would probably still prefer doing it on a new branch based on master and not including this mess in the repo (if we squashed everything this wouldn't be an issue...) otherwise lgtm |
a58ba54
to
6dbe43e
Compare
branch history fixed |
vi changed you should rebase/merge master into this branch and fix compilation errors |
Closes #357.