Implement IDisposable instead Destroyable in JobsInvoker
#76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkard2
requested changes
Jul 31, 2022
Comment on lines
16
to
17
| public Entity NextEmptyEntity => EntityWorld.NewEntity(); | ||
| public EntityWorld EmptyEntityWorld => new EntityWorld(); |
There was a problem hiding this comment.
i really dislike the way this is implemented, members appear as properties but they return a new value every time. intent would be expressed better with factory methods, such as CreateNextEmptyEntity and CreateEmptyEntityWorld. NextEmptyEntity is not that bad, but EmptyEntityWorld always returns a new instance (which is not expressed by name) of disposable class, which is expected to be cleaned up by the caller and i find that very unintuitive
kkard2
approved these changes
Jul 31, 2022
Vixenka
deleted the
feature/72/implement-idisposable-instead-destroyable-in-jobs-invoker
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #72