Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"export 'ɵɵdefineInjectable' was not found in '@angular/core' #363

Closed
andrefarzat opened this issue Jun 3, 2019 · 4 comments
Closed
Labels

Comments

@andrefarzat
Copy link

Once the versions 5.x were unpublished from npm, we needed to upgrade to 6.x
Following the small tutorial from the README.md, we are facing this issue (both on mac and windows machines):

Screen Shot 2019-06-03 at 19 05 22

Screen Shot 2019-06-03 at 19 16 03

The package.json is here: https://pastebin.com/uFgVXJH4

Digging on the code, if we change from ɵɵdefineInjectable to defineInjectable and from ɵɵinject to inject the code works. Can you see why this is happening ?

@tfohlmeister
Copy link

I can reproduce this error and confirm that downgrading ngx-page-scroll-core to 6.0.0 fixes this issue.

@andrefarzat
Copy link
Author

Regarding the diff: v6.0.0...v6.0.1
the main difference is the angular version which now is 8.x

I will downgrade to 6.0.0 ( forcing it on package.json ) while this isn't fixed

@Nolanus Nolanus added the bug label Jun 5, 2019
@Nolanus
Copy link
Owner

Nolanus commented Jun 5, 2019

Hi,

v5 of ngx-page-scroll is still available via npm and can be installed via npm install ngx-page-scroll@5.0.1.

Cause for the reported problem is a change in the compiled bundles which I overlooked (see angular/angular#30413). I'll release a new v6 version compiled using angular 7 tools shortly to fix this.

@Nolanus
Copy link
Owner

Nolanus commented Jun 5, 2019

@andrefarzat, please check the behaviour with library v6.0.2 and let me know whether it's working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants