Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't accept remote blocks without mixHash fields #518

Closed
fvictorio opened this issue Jun 17, 2024 · 3 comments
Closed

Don't accept remote blocks without mixHash fields #518

fvictorio opened this issue Jun 17, 2024 · 3 comments

Comments

@fvictorio
Copy link
Member

In #516 we changed the code to accept remote blocks without mixHash fields. If the field is not present, the default (zero) value is used. We did this to accommodate EVM-compatible chains that don't have this field.

We should re-visit this after we have proper support for alternative chain types. Mainnet-like chains should still expect this field to be present, but other chain types could make it optional.

@alcuadrado
Copy link
Member

I think the title of the issue makes an implicit assumption that we'd just reject working with networks that we don't fully understand/support. This is contrary to how Hardhat Network has been working so far.

@fvictorio
Copy link
Member Author

Yes, we need to discuss this more.

@Wodann suggested something I quite like: besides support for Ethereum Mainnet and Optimism, we could have a "Fallback" chain type which is more permissive. In that case, a mix hash wouldn't be accepted in "Ethereum Mainnet" mode, but it would in fallback mode.

@fvictorio
Copy link
Member Author

Closing this because it's pretty clear that we'll have that fallback chain type, which would make this a non-issue.

@fvictorio fvictorio closed this as not planned Won't fix, can't repro, duplicate, stale Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants