Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

send should support account as a to parameter #618

Closed
kanej opened this issue Oct 31, 2023 · 0 comments · Fixed by #623
Closed

send should support account as a to parameter #618

kanej opened this issue Oct 31, 2023 · 0 comments · Fixed by #623
Assignees
@zoeyTM
Labels
status:ready This issue is ready to be worked on type:improvement An enhancement to an existing feature
Milestone
v0.12.0 Release

Comments

@kanej
Copy link
Member

kanej commented Oct 31, 2023

The API should be modified to support passing an AccountRuntimeValue to the to of send. Currently it errors:

image
@kanej kanej added status:ready This issue is ready to be worked on type:improvement An enhancement to an existing feature and removed status:triaging labels Oct 31, 2023
@kanej kanej added this to the v0.12.0 Release milestone Oct 31, 2023
@zoeyTM zoeyTM self-assigned this Oct 31, 2023
@zoeyTM zoeyTM mentioned this issue Oct 31, 2023
Merged
@kanej kanej closed this as completed in #623 Nov 6, 2023
kanej added a commit that referenced this issue Nov 6, 2023
@zoeyTM @kanej
Allow sending to AccountRuntimeValue (#623)
06fec1c 
Support account runtime values in the `to` parameter of the send API.

Also add validation for send `to` addresses being addresses.

Sharpen the validation so that a string passed as the to address that
does not meet the requirements of being an ethereum address fails
`buildModule` validation.

This required updating the tests.

At the same time a sharper address comparison was added to the send
from/to test - which is what prompted the addition of the more general
address valid address check.

Fixes #618 

---------

Co-authored-by: John Kane <john@kanej.me>
kanej added a commit that referenced this issue Nov 6, 2023
@zoeyTM @kanej
Allow sending to AccountRuntimeValue (#623)
339c7f8 
Support account runtime values in the `to` parameter of the send API.

Also add validation for send `to` addresses being addresses.

Sharpen the validation so that a string passed as the to address that
does not meet the requirements of being an ethereum address fails
`buildModule` validation.

This required updating the tests.

At the same time a sharper address comparison was added to the send
from/to test - which is what prompted the addition of the more general
address valid address check.

Fixes #618 

---------

Co-authored-by: John Kane <john@kanej.me>
@kanej kanej mentioned this issue Nov 6, 2023
Merged
kanej added a commit that referenced this issue Nov 6, 2023
@zoeyTM @kanej
Allow sending to AccountRuntimeValue (#623)
ac2d2e2 
Support account runtime values in the `to` parameter of the send API.

Also add validation for send `to` addresses being addresses.

Sharpen the validation so that a string passed as the to address that
does not meet the requirements of being an ethereum address fails
`buildModule` validation.

This required updating the tests.

At the same time a sharper address comparison was added to the send
from/to test - which is what prompted the addition of the more general
address valid address check.

Fixes #618 

---------

Co-authored-by: John Kane <john@kanej.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zoeyTM zoeyTM

Labels
status:ready This issue is ready to be worked on type:improvement An enhancement to an existing feature
Projects
Hardhat Ignition
Archived in project
Milestone
v0.12.0 Release
Development

Successfully merging a pull request may close this issue.

Allow sending to AccountRuntimeValue NomicFoundation/hardhat-ignition
2 participants
@kanej @zoeyTM