Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add foundryup support for Windows #515

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Add foundryup support for Windows #515

wants to merge 2 commits into from

Conversation

akshatmittal
Copy link

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

This PR adds support for foundryup on Windows, especially if forge is not available in path or conflicts with other globally installed packages.

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2023 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (development@6c7d5b6). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 085ded1 differs from pull request most recent head af82c8d. Consider uploading reports for the commit af82c8d to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@              Coverage Diff               @@
##             development     #515   +/-   ##
==============================================
  Coverage               ?   53.22%           
==============================================
  Files                  ?      188           
  Lines                  ?     4825           
  Branches               ?      793           
==============================================
  Hits                   ?     2568           
  Misses                 ?     2020           
  Partials               ?      237

@beepidibop beepidibop mentioned this pull request Dec 11, 2023
Open
@Pedrojok01 Pedrojok01 mentioned this pull request Apr 10, 2024
Open
@Xanewok
Copy link
Collaborator

Xanewok commented Apr 30, 2024

@kanej Do you think this fix looks acceptable? I don't have a Windows box but I imagine that installing through

curl -L https://foundry.paradigm.xyz | bash.

Now installs to .foundry rather than .cargo, so this makes sense, I think.

Xanewok
Xanewok reviewed Apr 30, 2024
View reviewed changes
docs/publish-extension.md
@@ -25,6 +25,9 @@ release.

9. Push the release branch and open a pull request using the new changelog entry as the PR description
10. Generate a release candidate vsix file with `npm run package`, the vsix file should appear in the `./client` folder with the new version number

> NOTE: ensure .env file is populated with GA and Sentry secrets before packaging (see `./env.example`)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we drop this change, please?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the dev branch pulled back? I didn't add that. @kanej

But yeah, kinda cool that the PR is still valid after 10 months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xanewok Xanewok Xanewok left review comments

Assignees
No one assigned
Labels
None yet
Projects
hardhat-vscode
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@akshatmittal @codecov-commenter @Xanewok @kanej