release slang features to 1% of users #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarTawfik
added a commit
that referenced
this pull request
Apr 18, 2024
Just preparing this, in case anything goes wrong with the #556 release.
kanej
reviewed
Apr 18, 2024
| }, | ||
|
|
||
| "semanticHighlighting": { | ||
| "percent": 0 | ||
| "percent": 0.01 |
There was a problem hiding this comment.
Can I just double check. The percentage is expressed as a decimal rather than an integer?
There was a problem hiding this comment.
Yep, it's basically parseInt("2 random bytes", 16) / 65536 (in 0-1 range) and that's checked against these flag values:
hardhat-vscode/server/src/services/initialization/featureFlags.ts
Lines 71 to 73 in fe6254a
|
Like I mentioned, I'll merge this and keep a look on the metrics to see if we encounter any sort of problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.