Merge branch 'rethnet/main' into feat/rethnet-nodejs

NomicFoundation · Oct 27, 2022 · 7087f34 · 7087f34
2 parents 8c475da + 7027e82
commit 7087f34
Show file tree

Hide file tree

Showing 14 changed files with 101 additions and 33 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -3,7 +3,7 @@ name: Release
 on:
   push:
     branches:
-      - $default-branch
+      - main
 
 jobs:
   release:
@@ -26,6 +26,6 @@ jobs:
         run: yarn
 
       - name: Create Release Pull Request
-        uses: changesets/action@master
+        uses: changesets/action@v1
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -14,7 +14,7 @@ An issue being assigned does not mean that we are actively working on addressing
 
 ## Project structure
 
-This repository is a monorepo handled with [Yarn workspaces](https://classic.yarnpkg.com/en/docs/workspaces/).
+This repository is a monorepo handled with [Yarn v1](https://classic.yarnpkg.com/lang/en/) and [Yarn workspaces](https://classic.yarnpkg.com/en/docs/workspaces/).
 
 There's a folder for each subproject in `packages/`. All of them are plugins, except for `/packages/hardhat-core` which is the main project (i.e. the one that's published as [hardhat](https://npmjs.com/package/hardhat) in npm).
 

diff --git a/docs/src/content/hardhat-runner/plugins/plugins.ts b/docs/src/content/hardhat-runner/plugins/plugins.ts
@@ -120,6 +120,43 @@ const communityPlugins: IPlugin[] = [
     description: "Generate a static documentation site from NatSpec comments",
     tags: ["Documentation", "NatSpec"],
   },
+  {
+    name: "@solidstate/hardhat-4byte-uploader",
+    author: "Nick Barry",
+    authorUrl: "https://github.com/ItsNickBarry",
+    description:
+      "Upload local function selectors to the Ethereum Selector Database",
+    tags: ["Bytecode", "ABI"],
+  },
+  {
+    name: "@solidstate/hardhat-test-short-circuit",
+    author: "Nick Barry",
+    authorUrl: "https://github.com/ItsNickBarry",
+    description:
+      "Stop Hardhat test execution on demand and print output from completed tests",
+    tags: ["Testing", "Mocha"],
+  },
+  {
+    name: "@solidstate/hardhat-txn-dot-xyz",
+    author: "Nick Barry",
+    authorUrl: "https://github.com/ItsNickBarry",
+    description: "Generate and execute on-chain transactions via txn.xyz",
+    tags: ["Signing", "Scripts"],
+  },
+  {
+    name: "@solidstate/hardhat-bytecode-exporter",
+    author: "Nick Barry",
+    authorUrl: "https://github.com/ItsNickBarry",
+    description: "Automatically export contract bytecode on compilation",
+    tags: ["Bytecode", "Compiling"],
+  },
+  {
+    name: "@solidstate/hardhat-accounts",
+    author: "Nick Barry",
+    authorUrl: "https://github.com/ItsNickBarry",
+    description: "Output list of available accounts and their balances",
+    tags: ["Accounts", "Balances"],
+  },
   {
     name: "hardhat-watcher",
     author: "Xander Deseyn",
@@ -298,6 +335,14 @@ const communityPlugins: IPlugin[] = [
       "Hardhat plugin to deploy your smart contracts across multiple EVM chains with the same deterministic address.",
     tags: ["Deployment", "CREATE2", "Tasks"],
   },
+  {
+    name: "@tovarishfin/hardhat-yul",
+    author: "tovarishfin",
+    authorUrl: "https://codylamson.com",
+    description:
+      "An updated and working Hardhat plugin to compile the Yul and Yul+ languages into solc compatible artifacts. Works with .yul and .yulp file extensions",
+    tags: ["Yul", "Assembly", "Compiler", "Yul+"],
+  },
   {
     name: "@controlcpluscontrolv/hardhat-yul",
     author: "ControlCplusControlV",
@@ -555,6 +600,14 @@ const communityPlugins: IPlugin[] = [
       "Define your project's deployment in a simple manifest, then deploy and share it anywhere. Inspired by Docker, Terraform, and npm. https://usecannon.com/",
     tags: ["Tooling", "Deployment", "Testing"],
   },
+  {
+    name: "hardhat-etherscan-contract-cloner",
+    author: "Tuckson",
+    authorUrl: "https://github.com/TucksonDev",
+    description:
+      "Hardhat plugin for cloning verified contracts from any supported network using Etherscan's API.",
+    tags: ["Etherscan", "Clone", "Smart contract"],
+  },
   {
     name: "hardhat-interact",
     author: "Synthetix Core Contributors",

diff --git a/packages/hardhat-core/CHANGELOG.md b/packages/hardhat-core/CHANGELOG.md
@@ -1,5 +1,11 @@
 # hardhat
 
+## 2.12.1
+
+### Patch Changes
+
+- 145b12c7d: Fixed a problem that was preventing Hardhat from being used in Alpine Linux.
+
 ## 2.12.0
 
 ### Minor Changes

diff --git a/packages/hardhat-core/package.json b/packages/hardhat-core/package.json
@@ -1,6 +1,6 @@
 {
   "name": "hardhat",
-  "version": "2.12.0",
+  "version": "2.12.1",
   "author": "Nomic Labs LLC",
   "license": "MIT",
   "homepage": "https://hardhat.org",

diff --git a/packages/hardhat-core/src/internal/solidity/compiler/downloader.ts b/packages/hardhat-core/src/internal/solidity/compiler/downloader.ts
@@ -3,6 +3,8 @@ import fsExtra from "fs-extra";
 import debug from "debug";
 import os from "os";
 import { execFile } from "child_process";
+import { promisify } from "util";
+
 import { download } from "../../util/download";
 import { assertHardhatInvariant, HardhatError } from "../../core/errors";
 import { ERRORS } from "../../core/errors-list";
@@ -345,17 +347,15 @@ export class CompilerDownloader implements ICompilerDownloader {
     await fsExtra.createFile(this._getCompilerDoesntWorkFile(build));
   }
 
-  private _checkNativeSolc(build: CompilerBuild) {
+  private async _checkNativeSolc(build: CompilerBuild) {
     const solcPath = this._getCompilerBinaryPathFromBuild(build);
-    return new Promise((resolve) => {
-      try {
-        const process = execFile(solcPath, ["--version"]);
-        process.on("exit", (code) => {
-          resolve(code === 0);
-        });
-      } catch {
-        resolve(false);
-      }
-    });
+    const execFileP = promisify(execFile);
+
+    try {
+      await execFileP(solcPath, ["--version"]);
+      return true;
+    } catch {
+      return false;
+    }
   }
 }
diff --git a/packages/hardhat-ethers/CHANGELOG.md b/packages/hardhat-ethers/CHANGELOG.md
@@ -1,5 +1,11 @@
 # @nomiclabs/hardhat-ethers
 
+## 2.2.1
+
+### Patch Changes
+
+- 136f25a9e: `getContractAt` doesn't throw anymore if the given address is not a contract.
+
 ## 2.2.0
 
 ### Minor Changes

diff --git a/packages/hardhat-ethers/README.md b/packages/hardhat-ethers/README.md
@@ -81,8 +81,6 @@ The [`Contract`s](https://docs.ethers.io/v5/single-page/#/v5/api/contract/contra
 
 If there is no signer available, `getContractAt` returns [read-only](https://docs.ethers.io/v5/single-page/#/v5/api/contract/contract/-%23-Contract--readonly) contracts.
 
-If the address provided to `getContractAt` is not the address of a contract account, an error will be thrown.
-
 ## Usage
 
 There are no additional steps you need to take for this plugin to work.

diff --git a/packages/hardhat-ethers/package.json b/packages/hardhat-ethers/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@nomiclabs/hardhat-ethers",
-  "version": "2.2.0",
+  "version": "2.2.1",
   "description": "Hardhat plugin for ethers",
   "homepage": "https://github.com/nomiclabs/hardhat/tree/master/packages/hardhat-ethers",
   "repository": "github:nomiclabs/hardhat",

diff --git a/packages/hardhat-ethers/src/internal/helpers.ts b/packages/hardhat-ethers/src/internal/helpers.ts
@@ -303,13 +303,6 @@ export async function getContractAt(
   address: string,
   signer?: ethers.Signer
 ) {
-  if ((await hre.ethers.provider.getCode(address)) === "0x") {
-    throw new NomicLabsHardhatPluginError(
-      pluginName,
-      `${address} is not a contract account.`
-    );
-  }
-
   if (typeof nameOrAbi === "string") {
     const artifact = await hre.artifacts.readArtifact(nameOrAbi);
 

diff --git a/packages/hardhat-ethers/test/index.ts b/packages/hardhat-ethers/test/index.ts
@@ -710,12 +710,10 @@ describe("Ethers plugin", function () {
         });
 
         describe("by name and address", function () {
-          it("Should throw if address does not belong to a contract", async function () {
+          it("Should not throw if address does not belong to a contract", async function () {
             const address = await signers[0].getAddress();
-            return assert.isRejected(
-              this.env.ethers.getContractAt("Greeter", address),
-              `${address} is not a contract account.`
-            );
+            // shouldn't throw
+            await this.env.ethers.getContractAt("Greeter", address);
           });
 
           it("Should return an instance of a contract", async function () {

diff --git a/packages/hardhat-etherscan/CHANGELOG.md b/packages/hardhat-etherscan/CHANGELOG.md
@@ -1,5 +1,12 @@
 # @nomiclabs/hardhat-etherscan
 
+## 3.1.2
+
+### Patch Changes
+
+- eb3f7a7bd: - Added Arbitrum Goerli to the list of supported networks.
+  - Fixed the Optimism Goerli URLs.
+
 ## 3.1.1
 
 ### Patch Changes

diff --git a/packages/hardhat-etherscan/package.json b/packages/hardhat-etherscan/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@nomiclabs/hardhat-etherscan",
-  "version": "3.1.1",
+  "version": "3.1.2",
   "description": "Hardhat plugin for verifying contracts on etherscan",
   "repository": "github:nomiclabs/hardhat",
   "homepage": "https://github.com/nomiclabs/hardhat/tree/master/packages/hardhat-etherscan",

diff --git a/packages/hardhat-etherscan/src/ChainConfig.ts b/packages/hardhat-etherscan/src/ChainConfig.ts
@@ -96,8 +96,8 @@ export const chainConfig: ChainConfig = {
   optimisticGoerli: {
     chainId: 420,
     urls: {
-      apiURL: "https://api-goerli-optimistic.etherscan.io/api",
-      browserURL: "https://goerli-optimistic.etherscan.io/",
+      apiURL: "https://api-goerli-optimism.etherscan.io/api",
+      browserURL: "https://goerli-optimism.etherscan.io/",
     },
   },
   polygon: {
@@ -121,6 +121,13 @@ export const chainConfig: ChainConfig = {
       browserURL: "https://arbiscan.io/",
     },
   },
+  arbitrumGoerli: {
+    chainId: 421613,
+    urls: {
+      apiURL: "https://api-goerli.arbiscan.io/api",
+      browserURL: "https://goerli.arbiscan.io/",
+    },
+  },
   arbitrumTestnet: {
     chainId: 421611,
     urls: {