Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for user interruptions #5286

Merged
merged 3 commits into from
May 30, 2024
Merged

Add tests for user interruptions #5286

merged 3 commits into from
May 30, 2024

Conversation

zoeyTM
Copy link
Contributor

@zoeyTM zoeyTM commented May 29, 2024 •
edited

resolves #5233
resolves #5235

added tests for UserInterruptionsManagerImplementation and AsyncMutex

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 29, 2024 •
edited

⚠️ No Changeset found

Latest commit: 3687782

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented May 29, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 3:19pm

This was linked to issues May 29, 2024
Test the AsyncMutex #5235
Closed
Test the user interruptions manager #5233
Closed
schaable
schaable reviewed May 29, 2024
View reviewed changes
v-next/core/test/internal/user-interruptions/async-mutex.ts
let running = 0;
let maxRunning = 0;

async function run() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

schaable
schaable approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@schaable schaable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment, but LGTM

kanej
kanej reviewed May 30, 2024
View reviewed changes
v-next/core/package.json Outdated Show resolved Hide resolved
kanej
kanej approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@kanej kanej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Well done on the mutex test.

There are two points I am interested in:

  • is there value in testing around uninterrupted?
  • what do we think about tests of the default implementations?

I think we merge this PR and depending on the discussion, follow up on these two points.

@zoeyTM
Copy link
Contributor Author

zoeyTM commented May 30, 2024

@kanej

  • I don't really think there's value in testing uninterrupted since it would be identical to the mutex test
  • During the sync with Pato, we agreed that testing the default implementations would not really be worth the effort and that testing the dynamic handlers would be enough

@zoeyTM zoeyTM merged commit 070fbfb into v-next May 30, 2024
39 checks passed
@zoeyTM zoeyTM deleted the test/user-interruptions branch May 30, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanej kanej kanej approved these changes

@schaable schaable schaable approved these changes

Assignees

@kanej kanej

Labels
status:triaging
Projects
Hardhat
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test the AsyncMutex Test the user interruptions manager
3 participants
@zoeyTM @kanej @schaable