add public and internal to UnnamedFunctionAttribute till 0.5.0 (

#796) Enforced in ethereum/solidity#4376
NomicFoundation · Feb 13, 2024 · 59e1e53 · 59e1e53
1 parent 9aba0d9
commit 59e1e53
Show file tree

Hide file tree

Showing 17 changed files with 173 additions and 1 deletion.
diff --git a/.changeset/happy-pugs-pull.md b/.changeset/happy-pugs-pull.md
@@ -0,0 +1,5 @@
+---
+"@nomicfoundation/slang": patch
+---
+
+add `public` and `internal` to `UnnamedFunctionAttribute` till `0.5.0`
diff --git a/crates/solidity/inputs/language/src/definition.rs b/crates/solidity/inputs/language/src/definition.rs
@@ -2372,7 +2372,9 @@ codegen_language_macros::compile!(Language(
                                 EnumVariant(reference = ModifierInvocation),
                                 EnumVariant(reference = OverrideSpecifier),
                                 EnumVariant(reference = ExternalKeyword),
+                                EnumVariant(reference = InternalKeyword, enabled = Till("0.5.0")),
                                 EnumVariant(reference = PayableKeyword),
+                                EnumVariant(reference = PublicKeyword, enabled = Till("0.5.0")),
                                 EnumVariant(reference = PureKeyword),
                                 EnumVariant(reference = ViewKeyword)
                             ]

diff --git a/crates/solidity/outputs/cargo/crate/src/generated/language.rs b/crates/solidity/outputs/cargo/crate/src/generated/language.rs
diff --git a/crates/solidity/outputs/cargo/crate/src/generated/napi_interface/ast_selectors.rs b/crates/solidity/outputs/cargo/crate/src/generated/napi_interface/ast_selectors.rs
diff --git a/crates/solidity/outputs/cargo/tests/src/cst_output/generated/UnnamedFunctionDefinition.rs b/crates/solidity/outputs/cargo/tests/src/cst_output/generated/UnnamedFunctionDefinition.rs
diff --git a/crates/solidity/outputs/cargo/tests/src/cst_output/generated/mod.rs b/crates/solidity/outputs/cargo/tests/src/cst_output/generated/mod.rs
diff --git a/crates/solidity/outputs/npm/package/src/ast/generated/ast_types.ts b/crates/solidity/outputs/npm/package/src/ast/generated/ast_types.ts
diff --git a/crates/solidity/outputs/spec/generated/grammar.ebnf b/crates/solidity/outputs/spec/generated/grammar.ebnf
diff --git a/crates/solidity/outputs/spec/generated/public/02-definitions/08-functions.md b/crates/solidity/outputs/spec/generated/public/02-definitions/08-functions.md
diff --git a/...hots/cst_output/UnnamedFunctionDefinition/internal_attribute/generated/0.4.11-success.yml b/...hots/cst_output/UnnamedFunctionDefinition/internal_attribute/generated/0.4.11-success.yml
@@ -0,0 +1,23 @@
+# This file is generated automatically by infrastructure scripts. Please don't edit by hand.
+
+Source: >
+  1  │ function () internal {}                                                          │ 0..23
+
+Errors: []
+
+Tree:
+  - (UnnamedFunctionDefinition): # "function () internal {}\n" (0..24)
+      - (function_keyword꞉ FunctionKeyword): "function" # (0..8)
+      - (parameters꞉ ParametersDeclaration): # " ()" (8..11)
+          - (LeadingTrivia) ► (Whitespace): " " # (8..9)
+          - (open_paren꞉ OpenParen): "(" # (9..10)
+          - (close_paren꞉ CloseParen): ")" # (10..11)
+      - (attributes꞉ UnnamedFunctionAttributes): # " internal" (11..20)
+          - (item꞉ UnnamedFunctionAttribute): # " internal" (11..20)
+              - (LeadingTrivia) ► (Whitespace): " " # (11..12)
+              - (variant꞉ InternalKeyword): "internal" # (12..20)
+      - (body꞉ FunctionBody) ► (variant꞉ Block): # " {}\n" (20..24)
+          - (LeadingTrivia) ► (Whitespace): " " # (20..21)
+          - (open_brace꞉ OpenBrace): "{" # (21..22)
+          - (close_brace꞉ CloseBrace): "}" # (22..23)
+          - (TrailingTrivia) ► (EndOfLine): "\n" # (23..24)
diff --git a/...shots/cst_output/UnnamedFunctionDefinition/internal_attribute/generated/0.5.0-failure.yml b/...shots/cst_output/UnnamedFunctionDefinition/internal_attribute/generated/0.5.0-failure.yml
@@ -0,0 +1,23 @@
+# This file is generated automatically by infrastructure scripts. Please don't edit by hand.
+
+Source: >
+  1  │ function () internal {}                                                          │ 0..23
+
+Errors: # 1 total
+  - >
+    Error: Expected ExternalKeyword or Identifier or OpenBrace or OverrideKeyword or PayableKeyword or PureKeyword or Semicolon or ViewKeyword.
+       ╭─[crates/solidity/testing/snapshots/cst_output/UnnamedFunctionDefinition/internal_attribute/input.sol:1:12]
+       │
+     1 │ function () internal {}
+       │            ──────┬──────  
+       │                  ╰──────── Error occurred here.
+    ───╯
+
+Tree:
+  - (UnnamedFunctionDefinition): # "function () internal {}\n" (0..24)
+      - (function_keyword꞉ FunctionKeyword): "function" # (0..8)
+      - (parameters꞉ ParametersDeclaration): # " ()" (8..11)
+          - (LeadingTrivia) ► (Whitespace): " " # (8..9)
+          - (open_paren꞉ OpenParen): "(" # (9..10)
+          - (close_paren꞉ CloseParen): ")" # (10..11)
+      - (SKIPPED): " internal {}\n" # (11..24)
diff --git a/...shots/cst_output/UnnamedFunctionDefinition/internal_attribute/generated/0.6.0-failure.yml b/...shots/cst_output/UnnamedFunctionDefinition/internal_attribute/generated/0.6.0-failure.yml
@@ -0,0 +1,17 @@
+# This file is generated automatically by infrastructure scripts. Please don't edit by hand.
+
+Source: >
+  1  │ function () internal {}                                                          │ 0..23
+
+Errors: # 1 total
+  - >
+    Error: Expected end of file.
+       ╭─[crates/solidity/testing/snapshots/cst_output/UnnamedFunctionDefinition/internal_attribute/input.sol:1:1]
+       │
+     1 │ function () internal {}
+       │ ────────────┬───────────  
+       │             ╰───────────── Error occurred here.
+    ───╯
+
+Tree:
+  - (SKIPPED): "function () internal {}\n" # (0..24)
diff --git a/...idity/testing/snapshots/cst_output/UnnamedFunctionDefinition/internal_attribute/input.sol b/...idity/testing/snapshots/cst_output/UnnamedFunctionDefinition/internal_attribute/input.sol
@@ -0,0 +1 @@
+function () internal {}
diff --git a/...pshots/cst_output/UnnamedFunctionDefinition/public_attribute/generated/0.4.11-success.yml b/...pshots/cst_output/UnnamedFunctionDefinition/public_attribute/generated/0.4.11-success.yml
@@ -0,0 +1,23 @@
+# This file is generated automatically by infrastructure scripts. Please don't edit by hand.
+
+Source: >
+  1  │ function () public {}                                                            │ 0..21
+
+Errors: []
+
+Tree:
+  - (UnnamedFunctionDefinition): # "function () public {}\n" (0..22)
+      - (function_keyword꞉ FunctionKeyword): "function" # (0..8)
+      - (parameters꞉ ParametersDeclaration): # " ()" (8..11)
+          - (LeadingTrivia) ► (Whitespace): " " # (8..9)
+          - (open_paren꞉ OpenParen): "(" # (9..10)
+          - (close_paren꞉ CloseParen): ")" # (10..11)
+      - (attributes꞉ UnnamedFunctionAttributes): # " public" (11..18)
+          - (item꞉ UnnamedFunctionAttribute): # " public" (11..18)
+              - (LeadingTrivia) ► (Whitespace): " " # (11..12)
+              - (variant꞉ PublicKeyword): "public" # (12..18)
+      - (body꞉ FunctionBody) ► (variant꞉ Block): # " {}\n" (18..22)
+          - (LeadingTrivia) ► (Whitespace): " " # (18..19)
+          - (open_brace꞉ OpenBrace): "{" # (19..20)
+          - (close_brace꞉ CloseBrace): "}" # (20..21)
+          - (TrailingTrivia) ► (EndOfLine): "\n" # (21..22)
diff --git a/...apshots/cst_output/UnnamedFunctionDefinition/public_attribute/generated/0.5.0-failure.yml b/...apshots/cst_output/UnnamedFunctionDefinition/public_attribute/generated/0.5.0-failure.yml
@@ -0,0 +1,23 @@
+# This file is generated automatically by infrastructure scripts. Please don't edit by hand.
+
+Source: >
+  1  │ function () public {}                                                            │ 0..21
+
+Errors: # 1 total
+  - >
+    Error: Expected ExternalKeyword or Identifier or OpenBrace or OverrideKeyword or PayableKeyword or PureKeyword or Semicolon or ViewKeyword.
+       ╭─[crates/solidity/testing/snapshots/cst_output/UnnamedFunctionDefinition/public_attribute/input.sol:1:12]
+       │
+     1 │ function () public {}
+       │            ─────┬─────  
+       │                 ╰─────── Error occurred here.
+    ───╯
+
+Tree:
+  - (UnnamedFunctionDefinition): # "function () public {}\n" (0..22)
+      - (function_keyword꞉ FunctionKeyword): "function" # (0..8)
+      - (parameters꞉ ParametersDeclaration): # " ()" (8..11)
+          - (LeadingTrivia) ► (Whitespace): " " # (8..9)
+          - (open_paren꞉ OpenParen): "(" # (9..10)
+          - (close_paren꞉ CloseParen): ")" # (10..11)
+      - (SKIPPED): " public {}\n" # (11..22)
diff --git a/...apshots/cst_output/UnnamedFunctionDefinition/public_attribute/generated/0.6.0-failure.yml b/...apshots/cst_output/UnnamedFunctionDefinition/public_attribute/generated/0.6.0-failure.yml
@@ -0,0 +1,17 @@
+# This file is generated automatically by infrastructure scripts. Please don't edit by hand.
+
+Source: >
+  1  │ function () public {}                                                            │ 0..21
+
+Errors: # 1 total
+  - >
+    Error: Expected end of file.
+       ╭─[crates/solidity/testing/snapshots/cst_output/UnnamedFunctionDefinition/public_attribute/input.sol:1:1]
+       │
+     1 │ function () public {}
+       │ ───────────┬──────────  
+       │            ╰──────────── Error occurred here.
+    ───╯
+
+Tree:
+  - (SKIPPED): "function () public {}\n" # (0..22)
diff --git a/...olidity/testing/snapshots/cst_output/UnnamedFunctionDefinition/public_attribute/input.sol b/...olidity/testing/snapshots/cst_output/UnnamedFunctionDefinition/public_attribute/input.sol
@@ -0,0 +1 @@
+function () public {}