You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is it possible to get rid of allow(unused_imports) in the codebase? It is a good way to make sure that any publicly exposed APIs are covered with at least one simple/basic test.
Should we review instances of clippy::must_use_candidate (which we currently disable globally)?
Can NAPI-exposed properties be turned readonly? they are mutable by default.
The text was updated successfully, but these errors were encountered:
AntonyBlakey
changed the title
Audit all exposed APIs to dtermine if they should actually be private
Audit all exposed APIs to determine if they should actually be private
Dec 20, 2022
Not touching the grammar definition-related code since that's about to
be changed by
https://github.com/AntonyBlakey/slang/tree/AntonyBlakey/to_rust_types.
Somewhat related to #234,
I noticed that we have public extension traits that seem to only work
with the `LanguageDefinition` type. Maybe we should change these
one-function traits to free functions that accept the language
definition as the argument, instead?
Also not feeling strongly about
84912e8,
thought it's more of a nice-to-have.
Can we generate (and check in/source version) them?
rustdoc
JSON output: Tracking issue for RFC 2963: rustdoc JSON backend rust-lang/rust#76578typedoc
JSON output: https://typedoc.org/options/output/#jsonExample snapshot from Kotlin: https://github.com/ktorio/ktor/blob/58f2fa99c24a861e943bf686c6a6b31c6c9dbf7b/ktor-http/api/ktor-http.api
Questions
allow(unused_imports)
in the codebase? It is a good way to make sure that any publicly exposed APIs are covered with at least one simple/basic test.clippy::must_use_candidate
(which we currently disable globally)?readonly
? they are mutable by default.The text was updated successfully, but these errors were encountered: