Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimensional cake teleport to the wrong position #27

Closed
beiai opened this issue Jan 5, 2022 · 0 comments · Fixed by #28
Closed

Dimensional cake teleport to the wrong position #27

beiai opened this issue Jan 5, 2022 · 0 comments · Fixed by #28
Labels
bug Something isn't working

Comments

@beiai
Copy link

beiai commented Jan 5, 2022

Pack Version:
latest-dev-2dd8f8a

Description:
Dimensional cake teleport to the position (0, 0, 0), breaking the bedrock and then fall out of the world.

Steps To Reproduce:
eat the cake, first teleport everything is fine
use /spawn or /home teleport to other dimension
eat same cake again, it will send me to position 0,0,0
Nether Cake and End Cake have same problem

use /de invalidate PlayerName 0
in Void dimension eat Overworld Cake, use /home back and use Overworld Cake again
Overworld Cake also has the same problem

But, if I do not use /home /spawn, Forced to use cake to teleport back, then everything is fine
Even if you use /home /spawn again

@ghost ghost assigned serenibyss Jan 20, 2022
@Exaxxion Exaxxion transferred this issue from Nomifactory/Nomifactory Jan 20, 2022
@Exaxxion Exaxxion added the bug Something isn't working label Jan 20, 2022
Exaxxion pushed a commit that referenced this issue Feb 2, 2022
…#28)

Fixes #27 

When a player exclusively leaves a dimension they reached via cake by some means other than a cake, their return position via cake is not cached. This resulted in the next use of that dimension's cake spawning the player at {0,0,0} and falling out of the world.

This patch sanity-checks the retrieved return position, recomputing the destination if the Y position would spawn the player under the world. Unless the destination has become obstructed, eating the same cake should place the player in the same position as before.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants