Fixed failures and added javadocs

NonVolatileComputing · Aug 18, 2017 · 1ef2022 · 1ef2022
1 parent e5ff023
commit 1ef2022
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 6 deletions.
diff --git a/java/vector/src/main/codegen/templates/NullableValueVectors.java b/java/vector/src/main/codegen/templates/NullableValueVectors.java
@@ -219,7 +219,7 @@ public int getBufferSizeFor(final int valueCount) {
   }
 
   public ArrowBuf getBuffer() {
-    return values.getBuffer();
+    return values.getDataBuffer();
   }
 
   @Override

diff --git a/java/vector/src/main/java/org/apache/arrow/vector/ValueVector.java b/java/vector/src/main/java/org/apache/arrow/vector/ValueVector.java
@@ -235,7 +235,24 @@ interface Mutator {
     void generateTestData(int values);
   }
 
-  public ArrowBuf getDataBuffer();
+  /**
+   * Gets the underlying buffer associated with validity vector
+   *
+   * @return buffer
+   */
   public ArrowBuf getValidityBuffer();
+
+  /**
+   * Gets the underlying buffer associated with data vector
+   *
+   * @return buffer
+   */
+  public ArrowBuf getDataBuffer();
+
+  /**
+   * Gets the underlying buffer associated with offset vector
+   *
+   * @return buffer
+   */
   public ArrowBuf getOffsetBuffer();
 }
diff --git a/java/vector/src/main/java/org/apache/arrow/vector/complex/FixedSizeListVector.java b/java/vector/src/main/java/org/apache/arrow/vector/complex/FixedSizeListVector.java
@@ -309,17 +309,17 @@ public long getOffsetBufferAddress() {
   }
 
   @Override
-  public long getValidityBufferAddress() {
-    return (bits.getDataBuffer().memoryAddress());
+  public ArrowBuf getValidityBuffer() {
+    return (bits.getDataBuffer());
   }
 
   @Override
-  public long getDataBufferAddress() {
+  public ArrowBuf getDataBuffer() {
     throw new UnsupportedOperationException();
   }
 
   @Override
-  public long getOffsetBufferAddress() {
+  public ArrowBuf getOffsetBuffer() {
     throw new UnsupportedOperationException();
   }