Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change random_warmup::Bool keyword to method::Char #134

Merged
merged 19 commits into from
Jan 3, 2024
Merged

change random_warmup::Bool keyword to method::Char #134

merged 19 commits into from
Jan 3, 2024

Conversation

oameye
Copy link
Member

@oameye oameye commented Jan 2, 2024

To add later solver, we best opt for method::Char keyword then the now used random_warmup::Bool keyword

@oameye oameye requested a review from jkosata January 2, 2024 16:09
@oameye oameye mentioned this pull request Jan 2, 2024
Merged
@oameye oameye mentioned this pull request Jan 3, 2024
Merged
@oameye oameye requested a review from jdelpino January 3, 2024 08:49
@jdelpino jdelpino merged commit 01ad1a5 into master Jan 3, 2024
2 checks passed
@jdelpino jdelpino deleted the method-keyword branch January 3, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdelpino jdelpino jdelpino approved these changes

@jkosata jkosata Awaiting requested review from jkosata

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oameye @jdelpino @jkosata