Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in HetFrz code #109

Closed
gold2718 opened this issue Nov 8, 2023 · 1 comment
Closed

Bug in HetFrz code #109

gold2718 opened this issue Nov 8, 2023 · 1 comment
Assignees
@gold2718
Labels
bug Something isn't working
Milestone
NorESM2.1

Comments

@gold2718
Copy link

gold2718 commented Nov 8, 2023

What happened?

Changing the number of tasks changed answers in routine testing (e.g., ERP tests). This is usually an indication of a coding bug.

What are the steps to reproduce the bug?

Run any NorESM case which uses Oslo Aero.

What CAM-Nor tag were you using?

cam_cesm2_1_rel_05-Nor_v1.0.5

What machine were you running CAM (or NorESM) on?

Betzy

What compiler were you using?

Intel

Path to a case directory, if applicable

No response

Will you be addressing this bug yourself?

Yes

Extra info

There is an incorrect array reference in a call to calculateNumberConcentration

call calculateNumberConcentration(ncol, aer_cb, rho, CloudnumberConcentration)

should be

call calculateNumberConcentration(ncol, aer_cb(:,:,:,lchnk), rho, CloudnumberConcentration)
@gold2718 gold2718 added the bug Something isn't working label Nov 8, 2023
@gold2718 gold2718 added this to the NorESM2.1 milestone Nov 8, 2023
@gold2718 gold2718 self-assigned this Nov 8, 2023
@gold2718 gold2718 mentioned this issue Nov 17, 2023
Merged
gold2718 added a commit that referenced this issue Nov 24, 2023
@gold2718
Merge pull request #116 from mvertens/noresm2_1_develop
06f6ba4 
cam_cesm2_1_rel_05-Nor_v1.0.6: oslo-aero bugfixes and new compsets and testing

Summary: main oslo-aero bugfixes and compset/testing updates for noresm2.1 release

Contributors: @mvertens, @gold2718, @DirkOlivie, @oyvindseland 

Reviewers: @gold2718 

Purpose of changes:
- #24; clcoagTend output looks bizarre
- #109; Bug in HetFrz code
- #114; New tests to add for noresm2.1. release

Github PR URL: #116

Changes made to build system: Put in new noresm flag that is triggered by compset

Changes made to the namelist: None

Changes to the defaults for the boundary datasets: None

Substantial timing or memory changes: None

The main features in this PR are:
- bug fixes in the following two routines that now permit bfb answers with different pes
   -  src/chemistry/oslo_aero/hetfrz_classnuc_oslo.F90
   -  src/chemistry/oslo_aero/koagsub.F90
- updates to config_component.xml and config_compsets.xml to simplify the definition of compsets and remove deprecated ones
- cleanup of config_compsets.xml so that domain files are now set in cime config_grids.xml rather than in cam's config_compsets.xml

NOTE: this PR will also require an accompanying PR in CIME.

Testing: 
ERP_D_Ln9.f19_f19_mtn14.QPC6.betzy_intel.cam-outfrq9s
ERP_Ln9.f19_f19_mtn14.NF1850norbc.betzy_intel.cam-outfrq9s
@gold2718
Copy link
Author

Fixed in #116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gold2718 gold2718

Labels
bug Something isn't working
Projects
None yet
Milestone
NorESM2.1
Development

No branches or pull requests
1 participant
@gold2718