-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New auxiliary file for input from ww3dev #14
New auxiliary file for input from ww3dev #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please clean up the <desc>
fields. Many of the entries have two with one of them being useless or wrong. Also, it helps if they are all in the same place (below, some are before <values>
and some after).
</entry> | ||
<entry id="histaux_wav2med_file1_history_option"> | ||
<type>char</type> | ||
<category>aux_hist</category> | ||
<group>MED_attributes</group> | ||
<desc>Auxiliary mediator wav2med file1 output option</desc> | ||
<desc>history option type</desc> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the old description was, well, more descriptive? Why the change?
I would rather either have a better id (e.g., id="histaux_wav2med_file1_history_freq_option"
) or a better description (or, ideally, both).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the descriptions - but there is now only one auxiliary file (see my comment in the PR description).
</entry> | ||
<entry id="histaux_wav2med_file1_doavg"> | ||
<type>logical</type> | ||
<category>aux_hist</category> | ||
<group>MED_attributes</group> | ||
<desc>Auxiliary mediator wav2med file1 time averaged flag for file output.</desc> | ||
<desc>If true, use time average for aux file output.</desc> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be:
<desc>If true, use time average for aux file output.</desc> | |
<desc>If .true., use time average for aux file output.</desc> |
Also, what happens for .false.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gold2718 - I have updated the comments.
<type>char</type> | ||
<category>aux_hist</category> | ||
<group>MED_attributes</group> | ||
<desc>Auxiliary mediator wav2med average history output every day.</desc> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This description doesn't seem right, plus it smells of fresh paste, plus there is a better one after the values. Remove?
<type>char</type> | ||
<category>aux_hist</category> | ||
<group>MED_attributes</group> | ||
<desc>history option type</desc> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This description is not really useful. I would rather either have a better id (e.g., id="histaux_wav2med_file2_history_freq_option"
) or a better description (or, ideally, both).
… auxiliary file output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a missing <desc>
field but I have added that to a cleanup issue.
</values> | ||
<desc>Auxiliary mediator wav2med file1 time averaged flag for file output. | ||
If this flag is set to .false. only instantaneous output will be created in the auxiliary file.</desc> | ||
</entry> | ||
<entry id="histaux_wav2med_file1_auxname"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This entry has no <desc>
field.
Description of changes
WW3 will be sending daily files of all daily averaged variables and these will be written to a the auxiliary history file
wav.24h.avg
- but with thehistaux_wav2med_file2_doavg = .false.
(since the time averaging is done in the WW3 cap and not in the mediator.The key issue here is that the time averaging for these fields is done in the WW3 nuopc cap since the accumulation counter for each grid cell might be different and will depend on if the gridcell has a defined value for the different swell variables at that time. CMEPS does not currently have the capability to do that type of time averaging. So the fields for this auxiliary file are obtained from WW3 are written out as 'instantaneous' fields even though they contain time averaged values.
Renamed all of these variables in
fd_cesm.yaml
and inesmFldsExchange_cesm.F90
to have a_avg
suffix.Contributors other than yourself, if any: @anacarras
CMEPS Issues Fixed:
Are changes expected to change answers? bfb
Any User Interface Changes: yes - see the new cmeps namelists above
Testing performed
Verified that the follow case ran for 6 days and produced reasonable output in the mediator auxiliary files