-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Lmod hook to set to ^smcuda when loading OpenMPI module to work around bug + renaming #293
Conversation
…round bug + typos
Instance
|
Instance
|
Instance
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content-wise I think this looks ok.
As done in EESSI#473, we should build it for the different architectures and ingest it (because it changes the lmodrc.lua
). EESSI#473 also documents nicely how it was tested (we should not see the same message though since we don't have a neoverse_v1
software subdirectory).
For the future, I think it would be good to make a clickable link, e.g., EESSI/software-layer PR473 instead of just putting in the plain number in the description.
A little suggestion would also be to apply the same commit as done in EESSI#473 This might be done via git cherry-pick ...
(or some other command). Thus there is less doubt if the changes made here were identical or not to what was done in EESSI#473 Of course, this might not always be so easy in case of conflicts or more complex changes.
There are a number of other changes included here. They could be be done in a separate commit. Thus the commit adding the hook could be compared to the commit in EESSI#473.
…into EESSI-pr-473
bot: build inst:Saga-NESSI repo:nessi-2023.06-swl-deb11 arch:x86_64/intel/broadwell |
Updates by the bot instance
|
Updates by the bot instance
|
Updates by the bot instance
|
Updates by the bot instance
|
New job on instance
|
New job on instance
|
New job on instance
|
New job on instance
|
New job on instance
|
Broadwell nodes on Saga are busy. Try Fram. bot: build inst:Fram-NESSI repo:nessi-2023.06-swl-deb11 arch:x86_64/intel/broadwell |
Updates by the bot instance
|
Updates by the bot instance
|
Updates by the bot instance
|
Updates by the bot instance
|
New job on instance
|
Builds for all architectures succeeded. Cancelling pending job on Saga. |
Checklist before starting deployment (setting
|
Target architectures
Checklist for deployment/ingestion
command & logcommand
log
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All fine. Updated files ingested.
Sync NESSI software layer with EESSI software layer, EESSI PR473