Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10 - Add Multiple Ldap Hosts #11

Closed
wants to merge 4 commits into from
Closed

#10 - Add Multiple Ldap Hosts #11

wants to merge 4 commits into from

Conversation

uchetfield
Copy link

Create a way to add multiple ldap hosts and allow the end user which domain to authenticate against

Copy link
Author

@uchetfield uchetfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds the ability to add multiple hosts by changing the structure of the JSON in the appsettings.

Currently it only allows multiple hosts of the same type of user, ie ActiveDirectoryAppUser or OpenLdapAppUser

@uchetfield uchetfield mentioned this pull request Oct 31, 2018
@Nordes
Copy link
Owner

Nordes commented Nov 1, 2018

I guess my e-mail was not pushed over here ;). Sorry for the late reply. As I was mentioning in my mail, this have been requested by somebody else, but I had no time to investigate. I was proposing to use regular expression in order to discriminate what AD query needs to be done.

I will now look at the pull request ;). It might takes a few day due to my busy daily workload.

Note: I just saw that you added a dropdown in order to choose the domain. However, this will cause an issue when you do the API calls to IdentityServer in order to login from a front-end application (get the authentication token). I'll look more in depth in the pull request later probably this weekend)

Btw: great work.

SearchFilter = "(&(objectClass=posixAccount)(objectClass=person)(uid={0}))",
Ssl = false,
Port = 389

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need of the empty line

@@ -15,12 +15,27 @@ public interface ILdapService<out TUser>
/// <param name="password">The password.</param>
/// <returns>Returns the logged in user.</returns>
TUser Login(string username, string password);
/// <summary>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep the style for the spacing ;). One blank line before the summary of a method.

@murattdogan
Copy link

murattdogan commented Nov 5, 2018

Not Working Object reference not set to an instance of an object @uchetfield uchetfield
Ldap Timeout
adsiz
var user = searchResult.next(); old proje working
@uchetfield your project var user = searchResult.next(); new proje not working pleease
I need help muratdogan@hitit.edu.tr

@murattdogan
Copy link

    .AddLdapUsers<ActiveDirectoryAppUser>(Configuration.GetSection("multipleActiveDirectory"), UserStore.InMemory);

Multiple multipleActiveDirectory or OpenLdapAppUser MultipleLdapAppUser ?

@Nordes
Copy link
Owner

Nordes commented Nov 8, 2018

I was re-looking into your pull request. There's some things that I like. Please look at what I've done in the branch features/multi_ldap. (I will delete the branch once it's merged in develop.

Basically, I keep the retro-compatibility with the previous version. This way, there's no breaking changes.

@Nordes Nordes changed the title Add Multiple Ldap Hosts #10 - Add Multiple Ldap Hosts Nov 8, 2018
@uchetfield
Copy link
Author

I'm going to close this pull request because @Nordes created a better option

@uchetfield uchetfield closed this Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants