-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#10 - Add Multiple Ldap Hosts #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This adds the ability to add multiple hosts by changing the structure of the JSON in the appsettings.
Currently it only allows multiple hosts of the same type of user, ie ActiveDirectoryAppUser or OpenLdapAppUser
I guess my e-mail was not pushed over here ;). Sorry for the late reply. As I was mentioning in my mail, this have been requested by somebody else, but I had no time to investigate. I was proposing to use regular expression in order to discriminate what AD query needs to be done. I will now look at the pull request ;). It might takes a few day due to my busy daily workload.
Btw: great work. |
SearchFilter = "(&(objectClass=posixAccount)(objectClass=person)(uid={0}))", | ||
Ssl = false, | ||
Port = 389 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need of the empty line
@@ -15,12 +15,27 @@ public interface ILdapService<out TUser> | |||
/// <param name="password">The password.</param> | |||
/// <returns>Returns the logged in user.</returns> | |||
TUser Login(string username, string password); | |||
/// <summary> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keep the style for the spacing ;). One blank line before the summary of a method.
Not Working Object reference not set to an instance of an object @uchetfield uchetfield |
Multiple multipleActiveDirectory or OpenLdapAppUser MultipleLdapAppUser ? |
I was re-looking into your pull request. There's some things that I like. Please look at what I've done in the branch Basically, I keep the retro-compatibility with the previous version. This way, there's no breaking changes. |
I'm going to close this pull request because @Nordes created a better option |
Create a way to add multiple ldap hosts and allow the end user which domain to authenticate against