New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix README code #222
Fix README code #222
Conversation
These is a callback parameter in But could you also fix a typo in "Very, very long text that will NOT fit into MTU". |
Oh, true. I don't remember my own lib... |
I know that feeling ,-) |
It should be |
Hi, could you do the last change and I'll merge the PR? |
sure - but not yet sure how the last change would look like - if you mean setNotificationCallback(firstCharacteristic).with(callback); callback is not defined anywhere |
OK, let's change it to: setNotificationCallback(firstCharacteristic)
.with((device, data) -> log(Log.INFO, "Notification received: " + data)); as this can just demonstrate use of the API. |
Thanks again for your contribution! I've just merged the PR. |
also this line seems to be wrong:
setNotificationCallback(firstCharacteristic, callback)
I guess it should just be
setNotificationCallback(firstCharacteristic)
but did not add to this PR as not 100% sure about this yet
PS: love the humor in the README!