Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standalone server support to BleServerManager #231

Closed
wants to merge 2 commits into from

Conversation

usikder
Copy link
Contributor

@usikder usikder commented Aug 21, 2020

This makes it easier to use BleManager in a purely server role, as described in #229.

@CLAassistant
Copy link

CLAassistant commented Aug 21, 2020

CLA assistant check
All committers have signed the CLA.

@usikder
Copy link
Contributor Author

usikder commented Aug 25, 2020

Updated this PR to further flesh out BleManager's standalone server support. In particular, we initialize BleManager's BluetoothGattServer tracking metadata at an earlier time (when the server is open vs when optional client's unrelated services are discovered). We also make BleManager's BluetoothDevice settable so servers can set it since ConnectRequests aren't relevant to standalone servers.

@usikder usikder changed the title Add BluetoothGattServer as parameter to ServerObserver#onServerReady Add standalone server support to BleServerManager Aug 28, 2020
@philips77
Copy link
Member

How will the API of theBleManager work if BluetoothDevice if set without connecting? Ideally, I would like it to be in separated objects so that you don't have access to such API, not just that it would return errors when called.

@usikder
Copy link
Contributor Author

usikder commented Sep 4, 2020

Makes sense, I can think more about how to separate this API out more cleanly. For now, do you want to just merge the ServerObserver commit? If so, I can strip the top one off.

@Moes81
Copy link

Moes81 commented Mar 30, 2021

Since this thread is still "open", does this mean that stand-alone peripheral still doesn't work?
I'm trying this exact use case, but my callback are not triggered.

Copy link

@Neoangino Neoangino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supi

@philips77
Copy link
Member

I'm closing this PR as we're moving towards Kotlin BLE Library, which should support the only-server case in a better way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants