Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue when only one record is returned in CGMS profile. #360

Merged
merged 1 commit into from Feb 16, 2022

Conversation

sylwester-zielinski
Copy link
Contributor

@sylwester-zielinski sylwester-zielinski commented Feb 16, 2022

ContinuousGlucoseMeasurementResponse class's on..Received() method
can be invoked multiple times but the class can only store a single
record. As a result, all-but-the-last values were lost. To save all the values
the class has been modified to use a list as a values storage.

Copy link
Member

@philips77 philips77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't is be better to make the Item class Parcelable and read readParcelableArrayList in ...Respnse class?

ContinuousGlucoseMeasurementResponse class on..Received() method
can be invoked multiple times but the class can only store a single
record. As a result old values were lost. To save all the values
the class has been modified to use ArrayList as a values storage.
@philips77 philips77 merged commit b5e9580 into master Feb 16, 2022
@philips77 philips77 deleted the fix/cgms-missing-records branch February 16, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants