Making sure then() callback is called for RemoveBond request #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philips77
force-pushed
the
bugfix/race-condition-on-remove-bond
branch
from
540877d
to
ef22b9e
Compare
sylwester-zielinski
approved these changes
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #363.
Issue
When
removeBond()is executed, there are 2 callbacks called in result: disconnection and changing bond state toBOND_NONE. They, however, as shown in #363, can come in any order. Until now, the behaviour was different in any of those cases.Solution
This PR fixes the issue by ensuring that both the
onConnectionStateChangecallback and bond state broadcast listener are called. They still can be called in any order, but neither of them should block execution of the other. Thethencallback of the Remove Bond callback should be called in any case.