Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching stateAsFlow and bongingStateAsFlow from StateFlow to SharedFlow #489

Merged
merged 1 commit into from Apr 4, 2023

Conversation

philips77
Copy link
Member

This PR fixes #486.

The reason why Disconnected event was not caught using stateAsFlow on first connection when using autoConnect = true was that in this case the library was immediately starting reconnecting to the target peripheral using gatt.connect(). Before that, a new event Connecting was sent which was overwriting the state of the manager. As StateFlow doesn't have any buffering, a value that was not consumed is overwritten and was lost.
In case of using autoConnect = false or in following connections the immediate reconnection didn't happen and disconnection was reported successfully.

This PR breaks a the API. The type returned by stateAsFlow and bondingStateAsFlow is now Flow, not StateFlow. If you need a StateFlow, use .stateIn(...) modifier as such:
https://github.com/NordicSemiconductor/Android-nRF-Blinky/blob/44db91ec587bdf53bbb27cbb7c2f6048a7dfce2e/blinky/ble/src/main/java/no/nordicsemi/android/blinky/ble/BlinkyManager.kt#L44-L54

@philips77 philips77 merged commit c1fc3eb into main Apr 4, 2023
1 check passed
@philips77 philips77 deleted the fix/manager-state branch April 4, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: Auto Connect
1 participant